Issue 11106013: Fix a M23 stable crash issue for device enumeration on Mac

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 11106013: Fix a M23 stable crash issue for device enumeration on Mac (Closed)

Created:
8 years, 2 months ago by no longer working on chromium

Modified:
8 years, 2 months ago

Reviewers:
Avi (use Gerrit)

CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, jam

Base URL:
http://git.chromium.org/chromium/src.git@master

Visibility:
Public.

More Reviews

Description

IOKit sends out a device changed notification before the driver fully initializes the device. And Since chrome will enumerate the devices after getting the notification, this will crash on some specific USB devices if the device is being initialized while being enumerated. This patch change IOKit notification to use AudioObjectAddPropertyListener on kAudioHardwarePropertyDevices. By doing so, we will get notification after the driver initializes the devices. BUG=153411 TEST= manual test with Pepper flash device enumeration. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=161594

Patch Set 1 #

Created: 8 years, 2 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+31 lines, -14 lines)			Patch
	M	content/browser/device_monitor_mac.h	View		2 chunks	+7 lines, -2 lines	0 comments	Download
	M	content/browser/device_monitor_mac.cc	View		3 chunks	+24 lines, -12 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

no longer working on chromium

HI Avi, Could you please take a quick look at this fix? It is for ...

8 years, 2 months ago (2012-10-12 13:43:11 UTC) #1

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/xians@chromium.org/11106013/1

8 years, 2 months ago (2012-10-12 14:35:00 UTC) #3

Change committed as 161594

Expand Messages | Collapse Messages