Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(31)

Issue 11103021: Seccomp BPF: handle EINTR in error reporting setup. (Closed)

Created:
8 years, 2 months ago by jln (very slow on Chromium)
Modified:
8 years, 2 months ago
CC:
chromium-reviews, agl, jln+watch_chromium.org, Jorge Lucangeli Obes
Visibility:
Public.

Description

Seccomp BPF: handle EINTR in error reporting setup. Wrap dup2 with HANDLE_EINTR in the error reporting set-up for the BPF support detection process. We also print errno as an attempt to obtain more information on this puzzling bug. BUG=152530 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=161443

Patch Set 1 #

Total comments: 1

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -3 lines) Patch
M sandbox/linux/seccomp-bpf/sandbox_bpf.cc View 1 1 chunk +8 lines, -3 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
jln (very slow on Chromium)
Lei, would you mind taking a look at this trivial CL since Markus is away ...
8 years, 2 months ago (2012-10-11 02:06:37 UTC) #1
Lei Zhang
lgtm https://chromiumcodereview.appspot.com/11103021/diff/1/sandbox/linux/seccomp-bpf/sandbox_bpf.cc File sandbox/linux/seccomp-bpf/sandbox_bpf.cc (right): https://chromiumcodereview.appspot.com/11103021/diff/1/sandbox/linux/seccomp-bpf/sandbox_bpf.cc#newcode91 sandbox/linux/seccomp-bpf/sandbox_bpf.cc:91: const char *error_string = strerror(errno); nit: char*
8 years, 2 months ago (2012-10-11 05:15:13 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jln@chromium.org/11103021/3001
8 years, 2 months ago (2012-10-11 21:29:15 UTC) #3
commit-bot: I haz the power
8 years, 2 months ago (2012-10-11 23:27:30 UTC) #4
Change committed as 161443

Powered by Google App Engine
This is Rietveld 408576698