Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(868)

Issue 1110063002: Change vibrate type in WebNotificationData (Closed)

Created:
5 years, 7 months ago by Sanghyun Park
Modified:
5 years, 7 months ago
Reviewers:
Peter Beverloo
CC:
blink-reviews, peter+watch_chromium.org, dglazkov+blink
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Change vibrate type in WebNotificationData The vibrate data type is unsigned in blink, but this is clamped through kVibrationDurationMax. so, it is also fine to use an integer type. BUG=442132 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=194596

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -14 lines) Patch
M public/platform/modules/notifications/WebNotificationData.h View 3 chunks +2 lines, -14 lines 0 comments Download

Messages

Total messages: 13 (4 generated)
Sanghyun Park
5 years, 7 months ago (2015-04-28 07:00:07 UTC) #2
Peter Beverloo
lgtm
5 years, 7 months ago (2015-04-28 11:06:54 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1110063002/1
5 years, 7 months ago (2015-04-28 11:07:12 UTC) #5
Peter Beverloo
Sorry, wrong button :-( Won't this cause a whole bunch of unsigned -> signed implicit ...
5 years, 7 months ago (2015-04-28 11:09:47 UTC) #7
Sanghyun Park
On 2015/04/28 11:09:47, Peter Beverloo wrote: > Sorry, wrong button :-( > > Won't this ...
5 years, 7 months ago (2015-04-28 11:37:39 UTC) #8
Peter Beverloo
On 2015/04/28 11:37:39, Sanghyun Park wrote: > On 2015/04/28 11:09:47, Peter Beverloo wrote: > > ...
5 years, 7 months ago (2015-04-28 11:42:26 UTC) #9
Sanghyun Park
On 2015/04/28 11:42:26, Peter Beverloo wrote: > On 2015/04/28 11:37:39, Sanghyun Park wrote: > > ...
5 years, 7 months ago (2015-04-28 11:46:47 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1110063002/1
5 years, 7 months ago (2015-04-28 12:34:15 UTC) #12
commit-bot: I haz the power
5 years, 7 months ago (2015-04-28 12:34:51 UTC) #13
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=194596

Powered by Google App Engine
This is Rietveld 408576698