Issue 11100002: Add Proguard option to gyp template.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 11100002: Add Proguard option to gyp template. (Closed)

Created:
8 years, 2 months ago by shashi

Modified:
8 years, 2 months ago

Reviewers:
cjhopman, Yaron

CC:
chromium-reviews, peter+watch_chromium.org, bulach+watch_chromium.org, yfriedman+watch_chromium.org, ilevy+watch_chromium.org

Base URL:
http://git.chromium.org/chromium/src.git@master

Visibility:
Public.

More Reviews

Description

Add Proguard option to gyp template. Add proguard specific options to java_apk.gypi so that an apk can specify proguard flags. BUG=149214 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=161004

Patch Set 1 #

Total comments: 1

Patch Set 2 : rebase #

Created: 8 years, 2 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+19 lines, -4 lines)			Patch
	M	build/android/ant/chromium-apk.xml	View	1	2 chunks	+11 lines, -4 lines	0 comments	Download
	M	build/java_apk.gypi	View	1	2 chunks	+8 lines, -0 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

Yaron

lgtm https://chromiumcodereview.appspot.com/11100002/diff/1/build/java_apk.gypi File build/java_apk.gypi (right): https://chromiumcodereview.appspot.com/11100002/diff/1/build/java_apk.gypi#newcode55 build/java_apk.gypi:55: 'asset_location%': '', I guess we're racing to make ...

8 years, 2 months ago (2012-10-09 20:43:11 UTC) #2

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/shashishekhar@chromium.org/11100002/5002

8 years, 2 months ago (2012-10-09 22:58:38 UTC) #4

Change committed as 161004

Expand Messages | Collapse Messages