Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(556)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1109963003: Remove ICS support in VSyncMonitor. (Closed)

Created:
5 years, 8 months ago by aurimas (slooooooooow)
Modified:
5 years, 8 months ago
Reviewers:
no sievers, newt (away)
CC:
chromium-reviews, darin-cc_chromium.org, jam
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove ICS support in VSyncMonitor. Chrome no longer supports API 14 and 15 BUG=473837 Committed: https://crrev.com/962fc2256d7dd6c8ade0c13b3fbefb4a524b8a4c Cr-Commit-Position: refs/heads/master@{#327170}

Patch Set 1 #

Patch Set 2 : Remove silly comment #

Total comments: 1

Patch Set 3 : Remove lint suppression #

Unified diffs Side-by-side diffs Delta from patch set Stats (+39 lines, -140 lines) Patch
M content/public/android/javatests/src/org/chromium/content/browser/VSyncMonitorTest.java View 1 5 chunks +19 lines, -46 lines 0 comments Download
M ui/android/java/src/org/chromium/ui/VSyncMonitor.java View 1 2 9 chunks +20 lines, -94 lines 0 comments Download

Messages

Total messages: 15 (6 generated)
aurimas (slooooooooow)
sievers: PTAL
5 years, 8 months ago (2015-04-27 20:37:02 UTC) #2
no sievers
LGTM
5 years, 8 months ago (2015-04-27 21:43:50 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1109963003/20001
5 years, 8 months ago (2015-04-27 21:49:01 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/59372)
5 years, 8 months ago (2015-04-27 21:57:00 UTC) #7
aurimas (slooooooooow)
+newt for OWNERS
5 years, 8 months ago (2015-04-27 22:03:17 UTC) #9
newt (away)
rubber stamp LGTM after comment https://codereview.chromium.org/1109963003/diff/20001/ui/android/java/src/org/chromium/ui/VSyncMonitor.java File ui/android/java/src/org/chromium/ui/VSyncMonitor.java (right): https://codereview.chromium.org/1109963003/diff/20001/ui/android/java/src/org/chromium/ui/VSyncMonitor.java#newcode18 ui/android/java/src/org/chromium/ui/VSyncMonitor.java:18: @SuppressLint("NewApi") can we get ...
5 years, 8 months ago (2015-04-27 22:12:11 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1109963003/40001
5 years, 8 months ago (2015-04-27 22:23:19 UTC) #13
commit-bot: I haz the power
Committed patchset #3 (id:40001)
5 years, 8 months ago (2015-04-27 23:20:19 UTC) #14
commit-bot: I haz the power
5 years, 8 months ago (2015-04-27 23:21:10 UTC) #15
Message was sent while issue was closed. 
Patchset 3 (id:??) landed as
https://crrev.com/962fc2256d7dd6c8ade0c13b3fbefb4a524b8a4c
Cr-Commit-Position: refs/heads/master@{#327170}

Powered by Google App Engine
This is Rietveld 408576698