Issue 11099052: [Sync] Overwrite the local favicon with sync's favicon at association time

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 11099052: [Sync] Overwrite the local favicon with sync's favicon at association time (Closed)

Created:
8 years, 2 months ago by Nicolas Zea

Modified:
8 years, 2 months ago

Reviewers:
rlarocque

CC:
chromium-reviews, Raghu Simha, haitaol1, akalin, tim (not reviewing)

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

[Sync] Overwrite the local favicon with sync's favicon at association time Previously we would trigger an asynchronous write, but subsequently overwrite the sync favicon with the local favicon (which then gets overwritten with the sync when the asynchronous write completes), triggering unnecessary cycles. BUG=155137 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=161243

Patch Set 1 #

Created: 8 years, 2 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+3 lines, -6 lines)			Patch
	M	chrome/browser/sync/glue/bookmark_model_associator.cc	View		1 chunk	+3 lines, -6 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/zea@chromium.org/11099052/1

8 years, 2 months ago (2012-10-10 22:31:08 UTC) #3

Change committed as 161243

Expand Messages | Collapse Messages