[cc] Store CCLayerImpls as scoped_ptrs

[cc] Store CCLayerImpls as scoped_ptrs

Relanding https://codereview.chromium.org/11076013/

BUG=154451
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=161482

[enne (OOO), 2012-10-10 16:40:04]

No changes from previous patch.  Just another overconservative revert.  :(

[tfarina, 2012-10-10 19:15:30]

http://codereview.chromium.org/11099040/diff/1/cc/CCLayerImpl.h
File cc/CCLayerImpl.h (right):

http://codereview.chromium.org/11099040/diff/1/cc/CCLayerImpl.h#newcode19
cc/CCLayerImpl.h:19: #include "cc/scoped_ptr_vector.h"
nit: sort order

[jamesr, 2012-10-12 00:39:33]

lgtm

[commit-bot: I haz the power, 2012-10-12 00:42:15]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/enne@chromium.org/11099040/6001

[commit-bot: I haz the power, 2012-10-12 02:44:07]

Change committed as 161482

[falken, 2012-10-12 03:34:08]

I'm really sorry to revert this in spite of the "another overconservative
revert" comment. But several bots are now failing cc_unittests:

http://build.chromium.org/p/chromium.mac/builders/Mac10.6%20Tests%20%281%29/b...
http://build.chromium.org/p/chromium.mac/builders/Mac10.7%20Tests%20%281%29/b...
http://build.chromium.org/p/chromium.mac/builders/Mac%2010.6%20Tests%20%28dbg...
http://build.chromium.org/p/chromium.mac/builders/Mac%2010.7%20Tests%20%28dbg...

CCLayerTreeHostImplTests/CCLayerTreeHostImplTest.partialSwapReceivesDamageRect/0:

Assertion failed: (ptr_ != NULL), function operator->, file
../../base/memory/scoped_ptr.h, line 201.
[914:-1408298304:1011/200344:150492099812:ERROR:process_util_posix.cc(144)]
Received signal 6
0   libbase.dylib                       0x025c164f
base::debug::StackTrace::StackTrace() + 63
1   libbase.dylib                       0x025c15eb
base::debug::StackTrace::StackTrace() + 43
2   libbase.dylib                       0x0269cad7 base::(anonymous
namespace)::StackDumpSignalHandler(int, __siginfo*, __darwin_ucontext*) + 295
3   libsystem_c.dylib                   0x90fcd59b _sigtramp + 43
4   ???                                 0xffffffff 0x0 + 4294967295
5   libsystem_c.dylib                   0x90f68bdd abort + 167
6   libsystem_c.dylib                   0x90f9d20b __assert_rtn + 351
7   cc_unittests                        0x00160bdc
scoped_ptr<cc::CCLayerImpl>::operator->() const + 124
8   cc_unittests                        0x002a5331 (anonymous
namespace)::CCLayerTreeHostImplTest_partialSwapReceivesDamageRect_Test::TestBody()
+ 3601
9   cc_unittests                        0x0085c561 void
testing::internal::HandleSehExceptionsInMethodIfSupported<testing::Test,
void>(testing::Test*, void (testing::Test::*)(), char const*) + 145
10  cc_unittests                        0x00852fae void
testing::internal::HandleExceptionsInMethodIfSupported<testing::Test,
void>(testing::Test*, void (testing::Test::*)(), char const*) + 126
11  cc_unittests                        0x0084850e testing::Test::Run() + 254
12  cc_unittests                        0x00848967 testing::TestInfo::Run() +
263
13  cc_unittests                        0x00848ee9 testing::TestCase::Run() +
265
14  cc_unittests                        0x0084e235
testing::internal::UnitTestImpl::RunAllTests() + 821
15  cc_unittests                        0x0085a881 bool
testing::internal::HandleSehExceptionsInMethodIfSupported<testing::internal::UnitTestImpl,
bool>(testing::internal::UnitTestImpl*, bool
(testing::internal::UnitTestImpl::*)(), char const*) + 145
16  cc_unittests                        0x00854f4e bool
testing::internal::HandleExceptionsInMethodIfSupported<testing::internal::UnitTestImpl,
bool>(testing::internal::UnitTestImpl*, bool
(testing::internal::UnitTestImpl::*)(), char const*) + 126
17  cc_unittests                        0x0084dec4 testing::UnitTest::Run() +
148
18  cc_unittests                        0x007bb0b0 base::TestSuite::Run() + 256
19  cc_unittests                        0x0010b0f1 main + 161
20  cc_unittests                        0x0010b045 start + 53