Disable automatic flushes on compositor contexts.

Disable automatic flushes on compositor contexts.

The compositor contexts handle flushes themselves, so they don't need the automatic flushes, which can hurt performance.

BUG=152393
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=162434

[piman, 2012-10-16 03:07:14]

There is another place where we create command buffer WGC3D, it's in
content/browser/renderer_host/image_transport_factory.cc

I would set the value to true there, since it's what we want for the UI context,
and for the offscreen ones, we explicitly flush already anyway.

https://codereview.chromium.org/11099029/diff/7001/ui/compositor/compositor.cc
File ui/compositor/compositor.cc (right):

https://codereview.chromium.org/11099029/diff/7001/ui/compositor/compositor.c...
ui/compositor/compositor.cc:106: attrs.noAutomaticFlushes = !offscreen;
It's ignored anyway by WebGraphicsContext3DInProcessImpl. I wouldn't even worry
about setting it, but if you insist, just setting it to true is fine.

[jbauman, 2012-10-17 05:07:26]

Ok, added it to image_transport_factory.cc and removed it from
ui/compositor/compositor.cc

On 2012/10/16 03:07:14, piman wrote:
> There is another place where we create command buffer WGC3D, it's in
> content/browser/renderer_host/image_transport_factory.cc
> 
> I would set the value to true there, since it's what we want for the UI
context,
> and for the offscreen ones, we explicitly flush already anyway.
> 
> https://codereview.chromium.org/11099029/diff/7001/ui/compositor/compositor.cc
> File ui/compositor/compositor.cc (right):
> 
>
https://codereview.chromium.org/11099029/diff/7001/ui/compositor/compositor.c...
> ui/compositor/compositor.cc:106: attrs.noAutomaticFlushes = !offscreen;
> It's ignored anyway by WebGraphicsContext3DInProcessImpl. I wouldn't even
worry
> about setting it, but if you insist, just setting it to true is fine.

[piman, 2012-10-17 06:24:20]

lgtm

[commit-bot: I haz the power, 2012-10-17 06:40:05]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/jbauman@chromium.org/11099029/14001

[commit-bot: I haz the power, 2012-10-17 11:14:58]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/jbauman@chromium.org/11099029/14001

[commit-bot: I haz the power, 2012-10-17 16:55:08]

Change committed as 162434