Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(424)

Unified Diff: chrome/browser/history/history_backend.h

Issue 11099011: Prevent bookmarks from going out of sync part 2 (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 8 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/browser/history/history_backend.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/history/history_backend.h
diff --git a/chrome/browser/history/history_backend.h b/chrome/browser/history/history_backend.h
index d15f597abecd13e51790e23684c868cdabbc8cac..20df1c14d41d043bd954f0ba8370f9f24743a7da 100644
--- a/chrome/browser/history/history_backend.h
+++ b/chrome/browser/history/history_backend.h
@@ -501,6 +501,8 @@ class HistoryBackend : public base::RefCountedThreadSafe<HistoryBackend>,
FRIEND_TEST_ALL_PREFIXES(HistoryBackendTest, SetFaviconsReplaceBitmapData);
FRIEND_TEST_ALL_PREFIXES(HistoryBackendTest,
SetFaviconsSameFaviconURLForTwoPages);
+ FRIEND_TEST_ALL_PREFIXES(HistoryBackendTest,
+ UpdateFaviconMappingsAndFetchNoChange);
FRIEND_TEST_ALL_PREFIXES(HistoryBackendTest, MergeFaviconPageURLNotInDB);
FRIEND_TEST_ALL_PREFIXES(HistoryBackendTest, MergeFaviconPageURLInDB);
FRIEND_TEST_ALL_PREFIXES(HistoryBackendTest, MergeFaviconMaxFaviconsPerPage);
@@ -648,12 +650,9 @@ class HistoryBackend : public base::RefCountedThreadSafe<HistoryBackend>,
// For each entry in |favicon_bitmap_data|, if a favicon bitmap already
// exists at the entry's pixel size, replace the favicon bitmap's data with
// the entry's bitmap data. Otherwise add a new favicon bitmap.
- // |favicon_bitmap_added| is set to true if the function has added a favicon
- // bitmap.
void SetFaviconBitmaps(
FaviconID icon_id,
- const std::vector<FaviconBitmapData>& favicon_bitmap_data,
- bool* favicon_bitmap_added);
+ const std::vector<FaviconBitmapData>& favicon_bitmap_data);
// Returns true if |favicon_bitmap_data| and |icon_url_sizes| passed to
// SetFavicons() are valid.
@@ -675,11 +674,8 @@ class HistoryBackend : public base::RefCountedThreadSafe<HistoryBackend>,
// detailed description of FaviconSizes.
// Deletes any favicon bitmaps currently mapped to |icon_id| whose pixel
// sizes are not contained in |favicon_sizes|.
- // |favicon_bitmap_removed| is set to true if the function removed a favicon
- // bitmap.
void SetFaviconSizes(FaviconID icon_id,
- const FaviconSizes& favicon_sizes,
- bool* favicon_bitmap_removed);
+ const FaviconSizes& favicon_sizes);
// Returns true if there are favicons for |page_url| and one of the types in
// |icon_types|.
« no previous file with comments | « no previous file | chrome/browser/history/history_backend.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698