fileapi: Add modification time check for FileSystemFileStreamReader

fileapi: Add modification time check for FileSystemFileStreamReader

The check is added since BlobData has expected_modification_time field.
Add tests (mostly copied from LocalFileStreamReaderTest).

BUG=141835
TEST=content_unittests --gtest_filter="FileSystemFileStreamReaderTest.*"
TBR=jam@chromium.org

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=161853

[hashimoto, 2012-10-15 06:48:05]

Could you review this?

[kinuko, 2012-10-15 07:24:06]

looking good

http://codereview.chromium.org/11098067/diff/13001/webkit/fileapi/file_system...
File webkit/fileapi/file_system_file_stream_reader.cc (right):

http://codereview.chromium.org/11098067/diff/13001/webkit/fileapi/file_system...
webkit/fileapi/file_system_file_stream_reader.cc:134: platform_path,
initial_offset_, base::Time()));
I guess it might just work if you pass the expected_modification_time_ to the
LocalFileStreamReader here?

http://codereview.chromium.org/11098067/diff/13001/webkit/fileapi/file_system...
File webkit/fileapi/file_system_file_stream_reader_unittest.cc (right):

http://codereview.chromium.org/11098067/diff/13001/webkit/fileapi/file_system...
webkit/fileapi/file_system_file_stream_reader_unittest.cc:88:
MessageLoop::current()->RunAllPending();
Before submitting can you make sure FileStream::Close finishes in a valgrind
test? (Since it throws a task on a worker pool I'm not sure what's the best way
to guarantee)

[hashimoto, 2012-10-15 08:05:04]

http://codereview.chromium.org/11098067/diff/13001/webkit/fileapi/file_system...
File webkit/fileapi/file_system_file_stream_reader.cc (right):

http://codereview.chromium.org/11098067/diff/13001/webkit/fileapi/file_system...
webkit/fileapi/file_system_file_stream_reader.cc:134: platform_path,
initial_offset_, base::Time()));
On 2012/10/15 07:24:07, kinuko wrote:
> I guess it might just work if you pass the expected_modification_time_ to the
> LocalFileStreamReader here?

Sounds great, thanks!
Done.

http://codereview.chromium.org/11098067/diff/13001/webkit/fileapi/file_system...
File webkit/fileapi/file_system_file_stream_reader_unittest.cc (right):

http://codereview.chromium.org/11098067/diff/13001/webkit/fileapi/file_system...
webkit/fileapi/file_system_file_stream_reader_unittest.cc:88:
MessageLoop::current()->RunAllPending();
On 2012/10/15 07:24:07, kinuko wrote:
> Before submitting can you make sure FileStream::Close finishes in a valgrind
> test? (Since it throws a task on a worker pool I'm not sure what's the best
way
> to guarantee)

Confirmed it locally and will try with bots.
Since FileSystemTaskRunners::CreateMockTaskRunners() uses
MessageLoopProxy::current() for all task runners, I think RunAllPending() is
enough to flush all pending tasks.

[kinuko, 2012-10-15 08:30:05]

lgtm

[hashimoto, 2012-10-15 11:29:16]

TBR-ing jam@ for one-line content_tests.gypi change.

[commit-bot: I haz the power, 2012-10-15 11:29:26]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/hashimoto@chromium.org/11098067/22003

[commit-bot: I haz the power, 2012-10-15 13:28:08]

Change committed as 161853