Browser Plugin: Enable File Chooser (<input type="file">)

Browser Plugin: Enable File Chooser (<input type="file">)

Plumb RunFileChooser to the embedder's WebContentsDelegate so if the embedder is allowed to show
a file chooser, then so is the guest.

BUG=143801
TEST=<input type="file"> in guest

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=162392

[Charlie Reis, 2012-10-16 21:07:21]

This seems reasonable to me.  Do apps default to having the normal file chooser
hooked up, or do they have to do something special?   (I would hope that it
would default to the normal file chooser, and we could consider later adding
some way to specify a custom one for a guest.)

http://codereview.chromium.org/11098056/diff/1/content/browser/browser_plugin...
File content/browser/browser_plugin/browser_plugin_embedder.cc (right):

http://codereview.chromium.org/11098056/diff/1/content/browser/browser_plugin...
content/browser/browser_plugin/browser_plugin_embedder.cc:98:
guest->set_embedder_web_contents(web_contents());
Do we really want to set so many fields on the guest (RenderProcessHost,
WebContents, RenderViewHost from Sadrul's CL)?  I worry about them getting out
of sync in the future.

Seems like we only need to set the WebContents, since you can call
GetRenderViewHost() and GetRenderProcessHost() on the WebContents.  Less room
for error.

[Fady Samuel, 2012-10-17 00:28:06]

Yes, apps default to the normal file chooser. I've confirmed this works in
Mihai's browser tag demo.

http://codereview.chromium.org/11098056/diff/1/content/browser/browser_plugin...
File content/browser/browser_plugin/browser_plugin_embedder.cc (right):

http://codereview.chromium.org/11098056/diff/1/content/browser/browser_plugin...
content/browser/browser_plugin/browser_plugin_embedder.cc:98:
guest->set_embedder_web_contents(web_contents());
On 2012/10/16 21:07:21, creis wrote:
> Do we really want to set so many fields on the guest (RenderProcessHost,
> WebContents, RenderViewHost from Sadrul's CL)?  I worry about them getting out
> of sync in the future.
> 
> Seems like we only need to set the WebContents, since you can call
> GetRenderViewHost() and GetRenderProcessHost() on the WebContents.  Less room
> for error.

Done.

[Charlie Reis, 2012-10-17 00:50:01]

Great, LGTM.

[commit-bot: I haz the power, 2012-10-17 00:51:07]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/fsamuel@chromium.org/11098056/5001

[commit-bot: I haz the power, 2012-10-17 11:14:44]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/fsamuel@chromium.org/11098056/5001

[commit-bot: I haz the power, 2012-10-17 14:12:20]

Change committed as 162392