Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(178)

Issue 11098054: Removing webkit diff with Android tree (Closed)

Created:
8 years, 2 months ago by gone
Modified:
8 years, 2 months ago
CC:
chromium-reviews, yusukes+watch_chromium.org, jam, penghuang+watch_chromium.org, joi+watch-content_chromium.org, feature-media-reviews_chromium.org, darin-cc_chromium.org, James Su
Base URL:
http://git.chromium.org/chromium/src.git@master
Visibility:
Public.

Description

Removing webkit diff with Android tree Removes some :: global namespace scoping and updates comments. BUG= Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=161276

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -5 lines) Patch
M content/browser/renderer_host/render_widget_host_view_android.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M webkit/media/android/audio_decoder_android.cc View 1 chunk +1 line, -1 line 0 comments Download
M webkit/media/android/webmediaplayer_proxy_android.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 6 (0 generated)
gone
Just removes a few inconsistencies.
8 years, 2 months ago (2012-10-10 23:51:16 UTC) #1
sky
LGTM
8 years, 2 months ago (2012-10-11 00:49:46 UTC) #2
scherkus (not reviewing)
lgtm
8 years, 2 months ago (2012-10-11 00:53:15 UTC) #3
gone
On 2012/10/11 00:53:15, scherkus wrote: > lgtm Thanks!
8 years, 2 months ago (2012-10-11 00:54:15 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dfalcantara@chromium.org/11098054/1
8 years, 2 months ago (2012-10-11 00:54:35 UTC) #5
commit-bot: I haz the power
8 years, 2 months ago (2012-10-11 03:11:10 UTC) #6
Change committed as 161276

Powered by Google App Engine
This is Rietveld 408576698