Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(67)

Issue 11098034: Fix print settings units conversion for PPB_Printing. (Closed)

Created:
8 years, 2 months ago by raymes
Modified:
8 years, 2 months ago
Reviewers:
yzshen1
CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, jam
Visibility:
Public.

Description

Fix print settings units conversion for PPB_Printing. This fixes the conversion of print settings units ands adds some sanity checks to the ppapi printing test. BUG=none TBR=brettw Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=161266

Patch Set 1 #

Total comments: 1

Patch Set 2 : . #

Unified diffs Side-by-side diffs Delta from patch set Stats (+24 lines, -5 lines) Patch
M content/browser/renderer_host/pepper/pepper_print_settings_manager.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M ppapi/tests/test_printing.cc View 1 2 chunks +22 lines, -3 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
raymes
8 years, 2 months ago (2012-10-10 16:05:14 UTC) #1
yzshen1
lgtm https://codereview.chromium.org/11098034/diff/1/ppapi/tests/test_printing.cc File ppapi/tests/test_printing.cc (right): https://codereview.chromium.org/11098034/diff/1/ppapi/tests/test_printing.cc#newcode12 ppapi/tests/test_printing.cc:12: bool g_callback_triggered; no indent for namespace.
8 years, 2 months ago (2012-10-10 22:49:19 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/raymes@chromium.org/11098034/10002
8 years, 2 months ago (2012-10-10 23:48:46 UTC) #3
commit-bot: I haz the power
Presubmit check for 11098034-10002 failed and returned exit status 1. Running presubmit commit checks ...
8 years, 2 months ago (2012-10-10 23:48:49 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/raymes@chromium.org/11098034/10002
8 years, 2 months ago (2012-10-10 23:51:07 UTC) #5
commit-bot: I haz the power
8 years, 2 months ago (2012-10-11 02:07:07 UTC) #6
Change committed as 161266

Powered by Google App Engine
This is Rietveld 408576698