Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(280)

Issue 11096038: Move shared library copy and strip to java_apk.gypi (Closed)

Created:
8 years, 2 months ago by cjhopman
Modified:
8 years, 2 months ago
CC:
chromium-reviews, jam, ilevy+watch_chromium.org, joi+watch-content_chromium.org, bulach+watch_chromium.org, yfriedman+watch_chromium.org, darin-cc_chromium.org, peter+watch_chromium.org, android-webview-reviews_chromium.org
Base URL:
http://git.chromium.org/chromium/src.git@master
Visibility:
Public.

Description

Move shared library copy and strip to java_apk.gypi Also, for each such shared library included in an apk, create a link in the appropriate directory in <(android_product_out) to enable annotating native stack traces for those apks. BUG= Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=161440

Patch Set 1 #

Total comments: 1

Patch Set 2 : Rebase #

Patch Set 3 : Fix bad rebase #

Patch Set 4 : Workaround make generator bug #

Unified diffs Side-by-side diffs Delta from patch set Stats (+65 lines, -49 lines) Patch
M android_webview/android_webview.gyp View 1 2 chunks +2 lines, -15 lines 0 comments Download
A build/android/prepare_library_for_apk View 1 chunk +24 lines, -0 lines 0 comments Download
M build/java_apk.gypi View 1 2 3 2 chunks +35 lines, -4 lines 0 comments Download
M chrome/chrome_android.gypi View 1 2 3 1 chunk +2 lines, -15 lines 0 comments Download
M content/content_shell.gypi View 1 2 3 1 chunk +2 lines, -15 lines 0 comments Download

Messages

Total messages: 14 (0 generated)
cjhopman
8 years, 2 months ago (2012-10-10 01:43:22 UTC) #1
mkosiba (inactive)
LGTM for android_webview
8 years, 2 months ago (2012-10-10 09:07:15 UTC) #2
shashi
lgtm, I assume that android_product_out and android_strip are defined for SDK build. We may need ...
8 years, 2 months ago (2012-10-10 17:44:09 UTC) #3
Yaron
lgtm https://codereview.chromium.org/11096038/diff/1/build/android/prepare_library_for_apk File build/android/prepare_library_for_apk (right): https://codereview.chromium.org/11096038/diff/1/build/android/prepare_library_for_apk#newcode11 build/android/prepare_library_for_apk:11: then Can you cherry-pick this down after and ...
8 years, 2 months ago (2012-10-10 20:23:38 UTC) #4
cjhopman
brettw: chrome/ content/ for OWNERS
8 years, 2 months ago (2012-10-10 22:47:28 UTC) #5
brettw
owners lgtm
8 years, 2 months ago (2012-10-10 22:58:27 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/cjhopman@chromium.org/11096038/3002
8 years, 2 months ago (2012-10-10 23:28:31 UTC) #7
commit-bot: I haz the power
Sorry for I got bad news for ya. Compile failed with a clobber build. Your ...
8 years, 2 months ago (2012-10-10 23:35:46 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/cjhopman@chromium.org/11096038/5004
8 years, 2 months ago (2012-10-10 23:46:38 UTC) #9
commit-bot: I haz the power
Sorry for I got bad news for ya. Compile failed with a clobber build. Your ...
8 years, 2 months ago (2012-10-10 23:56:02 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/cjhopman@chromium.org/11096038/14002
8 years, 2 months ago (2012-10-11 18:56:28 UTC) #11
commit-bot: I haz the power
Sorry for I got bad news for ya. Compile failed with a clobber build. Your ...
8 years, 2 months ago (2012-10-11 19:21:07 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/cjhopman@chromium.org/11096038/14002
8 years, 2 months ago (2012-10-11 21:30:49 UTC) #13
commit-bot: I haz the power
8 years, 2 months ago (2012-10-11 23:23:50 UTC) #14
Change committed as 161440

Powered by Google App Engine
This is Rietveld 408576698