Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(630)

Unified Diff: sandbox/linux/seccomp-bpf/syscall_iterator.h

Issue 11096012: Add a platform-specific syscall number iterator. (Closed) Base URL: http://git.chromium.org/chromium/src.git@master
Patch Set: Rename #define's and extract ARM private syscall logic. Created 8 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: sandbox/linux/seccomp-bpf/syscall_iterator.h
diff --git a/sandbox/linux/seccomp-bpf/syscall_iterator.h b/sandbox/linux/seccomp-bpf/syscall_iterator.h
new file mode 100644
index 0000000000000000000000000000000000000000..83ebdecadbd613cd3e95ca3589a724b2ca274620
--- /dev/null
+++ b/sandbox/linux/seccomp-bpf/syscall_iterator.h
@@ -0,0 +1,43 @@
+// Copyright (c) 2012 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#ifndef SANDBOX_LINUX_SECCOMP_BPF_SYSCALL_ITERATOR_H__
+#define SANDBOX_LINUX_SECCOMP_BPF_SYSCALL_ITERATOR_H__
+
+#include <stdint.h>
+
+namespace playground2 {
+
+class SyscallIterator {
+ public:
+ // Iterates over the entire system call range from 0..0xFFFFFFFFu. This
+ // iterator is aware of how system calls look like and will skip quickly
+ // over ranges that can't contain system calls. It iterates more slowly
jln (very slow on Chromium) 2012/10/11 22:42:00 It should be documented (and asserted from unit te
Jorge Lucangeli Obes 2012/10/12 17:58:23 Invalid and InvalidOnly tests in syscall_iterator_
+ // whenever it reaches a range that is potentially problematic. And it
+ // iterates over individual values whenever it is in the normal range for
+ // system calls (typically MIN_SYSCALL..MAX_SYSCALL).
+ // If "invalid_only" is "true", the iterator still iterates from
+ // 0..0xFFFFFFFFu, but it never returns values from the range of valid
+ // system call numbers. This feature can be used when verifying that all
+ // "impossible" system call values are treated the same.
+ explicit SyscallIterator(bool invalid_only)
+ : invalid_only_(invalid_only),
+ done_(false),
+ num_(0) {
+ }
+
+ bool Done() const { return done_; }
+ uint32_t Next();
+ static bool IsArmPrivate(uint32_t num);
+ static bool IsValid(uint32_t num);
+
+ private:
+ bool invalid_only_;
+ bool done_;
+ uint32_t num_;
+};
+
+} // namespace
+
+#endif // SANDBOX_LINUX_SECCOMP_BPF_SYSCALL_ITERATOR_H__

Powered by Google App Engine
This is Rietveld 408576698