New action box button images and supporting code

chrome/browser/ui/views/location_bar/action_box_button_view.h

Index: chrome/browser/ui/views/location_bar/action_box_button_view.h
diff --git a/chrome/browser/ui/views/location_bar/action_box_button_view.h b/chrome/browser/ui/views/location_bar/action_box_button_view.h
index d20b8476c03ca8fbae2417aaef4b2072c9311ddb..887c7303399226324cceed92431c2d9b036fbd17 100644
--- a/chrome/browser/ui/views/location_bar/action_box_button_view.h
+++ b/chrome/browser/ui/views/location_bar/action_box_button_view.h
@@ -25,6 +25,10 @@ class ActionBoxButtonView : public views::MenuButton,
    return &controller_;
   }
 
+  // Thickness of the top transparent area on a button image that overlaps
+  // location bar border.

[Peter Kasting, 2012/10/13 00:25:29]

Nit: Slightly better:

  // The action box image is transparent at the top and bottom and overlaps the
  // location bar border.
  static const int kBorderOverlap;

(See also the .cc file regarding naming)

[yefimt, 2012/10/13 00:51:30]

Done.

+  static const int kTopBorderOverlapThickness;

[Peter Kasting, 2012/10/13 00:25:29]

Nit: Per the Google style guide, constants go above constructor/destructor

[yefimt, 2012/10/13 00:51:30]

Done.

+
  private:
   // Overridden from views::CustomButton:
   virtual void GetAccessibleState(ui::AccessibleViewState* state) OVERRIDE;
@@ -33,6 +37,10 @@ class ActionBoxButtonView : public views::MenuButton,
   virtual void OnMenuButtonClicked(View* source,
                                    const gfx::Point& point) OVERRIDE;
 
+  // Overridden from veiws::View:

[Peter Kasting, 2012/10/13 00:25:29]

Nit: veiws -> views

[yefimt, 2012/10/13 00:51:30]

Done.

+  virtual bool HasHitTestMask() const;
+  virtual void GetHitTestMask(gfx::Path* mask) const;
+
   // Overridden from ActionBoxButtonController::Delegate:
   virtual void ShowMenu(scoped_ptr<ActionBoxMenuModel> menu_model) OVERRIDE;