Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1078)

Side by Side Diff: content/renderer/render_view_impl.h

Issue 11094062: Cleanup RenderViewImpl override methods from WebKit (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Do not comment out methods (was a mistake) Created 8 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « no previous file | content/renderer/render_view_impl.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CONTENT_RENDERER_RENDER_VIEW_IMPL_H_ 5 #ifndef CONTENT_RENDERER_RENDER_VIEW_IMPL_H_
6 #define CONTENT_RENDERER_RENDER_VIEW_IMPL_H_ 6 #define CONTENT_RENDERER_RENDER_VIEW_IMPL_H_
7 7
8 #include <deque> 8 #include <deque>
9 #include <map> 9 #include <map>
10 #include <set> 10 #include <set>
(...skipping 474 matching lines...) Expand 10 before | Expand all | Expand 10 after
485 virtual void setKeyboardFocusURL(const WebKit::WebURL& url); 485 virtual void setKeyboardFocusURL(const WebKit::WebURL& url);
486 virtual void startDragging(WebKit::WebFrame* frame, 486 virtual void startDragging(WebKit::WebFrame* frame,
487 const WebKit::WebDragData& data, 487 const WebKit::WebDragData& data,
488 WebKit::WebDragOperationsMask mask, 488 WebKit::WebDragOperationsMask mask,
489 const WebKit::WebImage& image, 489 const WebKit::WebImage& image,
490 const WebKit::WebPoint& imageOffset); 490 const WebKit::WebPoint& imageOffset);
491 virtual bool acceptsLoadDrops(); 491 virtual bool acceptsLoadDrops();
492 virtual void focusNext(); 492 virtual void focusNext();
493 virtual void focusPrevious(); 493 virtual void focusPrevious();
494 virtual void focusedNodeChanged(const WebKit::WebNode& node); 494 virtual void focusedNodeChanged(const WebKit::WebNode& node);
495 virtual void numberOfWheelEventHandlersChanged(unsigned num_handlers);
496 virtual void hasTouchEventHandlers(bool has_handlers);
495 virtual void didUpdateLayout(); 497 virtual void didUpdateLayout();
496 virtual void navigateBackForwardSoon(int offset); 498 virtual void navigateBackForwardSoon(int offset);
497 virtual int historyBackListCount(); 499 virtual int historyBackListCount();
498 virtual int historyForwardListCount(); 500 virtual int historyForwardListCount();
499 virtual void postAccessibilityNotification( 501 virtual void postAccessibilityNotification(
500 const WebKit::WebAccessibilityObject& obj, 502 const WebKit::WebAccessibilityObject& obj,
501 WebKit::WebAccessibilityNotification notification); 503 WebKit::WebAccessibilityNotification notification);
502 virtual void didUpdateInspectorSetting(const WebKit::WebString& key, 504 virtual void didUpdateInspectorSetting(const WebKit::WebString& key,
503 const WebKit::WebString& value); 505 const WebKit::WebString& value);
504 virtual WebKit::WebGeolocationClient* geolocationClient(); 506 virtual WebKit::WebGeolocationClient* geolocationClient();
(...skipping 16 matching lines...) Expand all
521 virtual void cancelScheduledContentIntents(); 523 virtual void cancelScheduledContentIntents();
522 virtual WebKit::WebContentDetectionResult detectContentAround( 524 virtual WebKit::WebContentDetectionResult detectContentAround(
523 const WebKit::WebHitTestResult& touch_hit); 525 const WebKit::WebHitTestResult& touch_hit);
524 #endif 526 #endif
525 527
526 // WebKit::WebFrameClient implementation ------------------------------------- 528 // WebKit::WebFrameClient implementation -------------------------------------
527 529
528 virtual WebKit::WebPlugin* createPlugin( 530 virtual WebKit::WebPlugin* createPlugin(
529 WebKit::WebFrame* frame, 531 WebKit::WebFrame* frame,
530 const WebKit::WebPluginParams& params); 532 const WebKit::WebPluginParams& params);
531 virtual WebKit::WebPlugin* createPluginReplacement(
532 WebKit::WebFrame* frame,
533 const WebKit::WebPluginParams& params);
534 virtual WebKit::WebSharedWorker* createSharedWorker( 533 virtual WebKit::WebSharedWorker* createSharedWorker(
535 WebKit::WebFrame* frame, const WebKit::WebURL& url, 534 WebKit::WebFrame* frame, const WebKit::WebURL& url,
536 const WebKit::WebString& name, unsigned long long documentId); 535 const WebKit::WebString& name, unsigned long long documentId);
537 virtual WebKit::WebMediaPlayer* createMediaPlayer( 536 virtual WebKit::WebMediaPlayer* createMediaPlayer(
538 WebKit::WebFrame* frame, 537 WebKit::WebFrame* frame,
539 const WebKit::WebURL& url, 538 const WebKit::WebURL& url,
540 WebKit::WebMediaPlayerClient* client); 539 WebKit::WebMediaPlayerClient* client);
541 virtual WebKit::WebApplicationCacheHost* createApplicationCacheHost( 540 virtual WebKit::WebApplicationCacheHost* createApplicationCacheHost(
542 WebKit::WebFrame* frame, 541 WebKit::WebFrame* frame,
543 WebKit::WebApplicationCacheHostClient* client); 542 WebKit::WebApplicationCacheHostClient* client);
(...skipping 88 matching lines...) Expand 10 before | Expand all | Expand 10 after
632 virtual void didDisplayInsecureContent(WebKit::WebFrame* frame); 631 virtual void didDisplayInsecureContent(WebKit::WebFrame* frame);
633 virtual void didRunInsecureContent( 632 virtual void didRunInsecureContent(
634 WebKit::WebFrame* frame, 633 WebKit::WebFrame* frame,
635 const WebKit::WebSecurityOrigin& origin, 634 const WebKit::WebSecurityOrigin& origin,
636 const WebKit::WebURL& target); 635 const WebKit::WebURL& target);
637 virtual void didExhaustMemoryAvailableForScript(WebKit::WebFrame* frame); 636 virtual void didExhaustMemoryAvailableForScript(WebKit::WebFrame* frame);
638 virtual void didCreateScriptContext(WebKit::WebFrame* frame, 637 virtual void didCreateScriptContext(WebKit::WebFrame* frame,
639 v8::Handle<v8::Context>, 638 v8::Handle<v8::Context>,
640 int extension_group, 639 int extension_group,
641 int world_id); 640 int world_id);
642 // TODO(koz): Remove once WebKit no longer calls this.
643 virtual void didCreateScriptContext(WebKit::WebFrame* frame,
644 v8::Handle<v8::Context>,
645 int world_id);
646 virtual void willReleaseScriptContext(WebKit::WebFrame* frame, 641 virtual void willReleaseScriptContext(WebKit::WebFrame* frame,
647 v8::Handle<v8::Context>, 642 v8::Handle<v8::Context>,
648 int world_id); 643 int world_id);
649 virtual void didChangeScrollOffset(WebKit::WebFrame* frame); 644 virtual void didChangeScrollOffset(WebKit::WebFrame* frame);
650 virtual void numberOfWheelEventHandlersChanged(unsigned num_handlers);
651 virtual void hasTouchEventHandlers(bool has_handlers);
652 virtual void didChangeContentsSize(WebKit::WebFrame* frame, 645 virtual void didChangeContentsSize(WebKit::WebFrame* frame,
653 const WebKit::WebSize& size); 646 const WebKit::WebSize& size);
654 virtual void reportFindInPageMatchCount(int request_id, 647 virtual void reportFindInPageMatchCount(int request_id,
655 int count, 648 int count,
656 bool final_update); 649 bool final_update);
657 virtual void reportFindInPageSelection(int request_id, 650 virtual void reportFindInPageSelection(int request_id,
658 int active_match_ordinal, 651 int active_match_ordinal,
659 const WebKit::WebRect& sel); 652 const WebKit::WebRect& sel);
660 virtual void openFileSystem(WebKit::WebFrame* frame, 653 virtual void openFileSystem(WebKit::WebFrame* frame,
661 WebKit::WebFileSystem::Type type, 654 WebKit::WebFileSystem::Type type,
(...skipping 919 matching lines...) Expand 10 before | Expand all | Expand 10 after
1581 // bunch of stuff, you should probably create a helper class and put your 1574 // bunch of stuff, you should probably create a helper class and put your
1582 // data and methods on that to avoid bloating RenderView more. You can 1575 // data and methods on that to avoid bloating RenderView more. You can
1583 // use the Observer interface to filter IPC messages and receive frame change 1576 // use the Observer interface to filter IPC messages and receive frame change
1584 // notifications. 1577 // notifications.
1585 // --------------------------------------------------------------------------- 1578 // ---------------------------------------------------------------------------
1586 1579
1587 DISALLOW_COPY_AND_ASSIGN(RenderViewImpl); 1580 DISALLOW_COPY_AND_ASSIGN(RenderViewImpl);
1588 }; 1581 };
1589 1582
1590 #endif // CONTENT_RENDERER_RENDER_VIEW_IMPL_H_ 1583 #endif // CONTENT_RENDERER_RENDER_VIEW_IMPL_H_
OLDNEW
« no previous file with comments | « no previous file | content/renderer/render_view_impl.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698