Issue 11094062: Cleanup RenderViewImpl override methods from WebKit

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 11094062: Cleanup RenderViewImpl override methods from WebKit (Closed)

Created:
8 years, 2 months ago by boliu

Modified:
8 years, 2 months ago

Reviewers:
jamesr, koz (OOO until 15th September)

CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, jam

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Cleanup RenderViewImpl override methods from WebKit createPluginReplacement and didCreateScriptContext is no longer in WebKit::WebFrameClient or called anywhere else. Removing them. numberOfWheelEventHandlersChanged and hasTouchEventHandlers are overriding methods from WebKit::WebViewClient. Moving them up. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=161384

Patch Set 1 #

Patch Set 2 : Re-add and move methods from WebViewClient. #

Patch Set 3 : Do not comment out methods (was a mistake) #

Created: 8 years, 2 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+10 lines, -35 lines)			Patch
	M	content/renderer/render_view_impl.h	View	1 2	3 chunks	+2 lines, -9 lines	0 comments	Download
	M	content/renderer/render_view_impl.cc	View	1 2	4 chunks	+8 lines, -26 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

boliu

Hi koz, I found a two methods in render_view_impl that can be removed and two ...

8 years, 2 months ago (2012-10-11 05:54:49 UTC) #1

boliu

Add owner review. Somehow thought koz was owner in my lack of sleep state last ...

8 years, 2 months ago (2012-10-11 16:29:40 UTC) #2

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/boliu@chromium.org/11094062/2004

8 years, 2 months ago (2012-10-11 17:02:24 UTC) #4

Change committed as 161384

Expand Messages | Collapse Messages