BrowserTestBase::CreateTestServer should accept FilePath

BrowserTestBase::CreateTestServer should accept FilePath

BUG=none
TEST=browser_tests, content_browsertests


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=161318

[Takashi Toyoshima, 2012-10-10 05:47:52]

Hi Sky, could you review this trivial change?

Currently, some tests launch TestServer like
CreateTestServer("content/test/data").
But, I think we should use FilePath().Append()... approach for specifying the
test data path.

FYI, this change is forked from https://codereview.chromium.org/11087027/ and
based on rsleevi's comment.

[sky, 2012-10-10 16:13:46]

LGTM

[Ryan Sleevi, 2012-10-10 17:38:40]

I was wrong about the forward slashes in literals comment, but I support the
change to using FilePath here, so LGTM, mod nits.

https://codereview.chromium.org/11094040/diff/1/chrome/test/base/in_process_b...
File chrome/test/base/in_process_browser_test.cc (right):

https://codereview.chromium.org/11094040/diff/1/chrome/test/base/in_process_b...
chrome/test/base/in_process_browser_test.cc:84:
.Append(FILE_PATH_LITERAL("data")));
FILE_PATH_LITERAL("chrome/test/data") ?

https://codereview.chromium.org/11094040/diff/1/content/test/content_browser_...
File content/test/content_browser_test.cc (right):

https://codereview.chromium.org/11094040/diff/1/content/test/content_browser_...
content/test/content_browser_test.cc:46: .Append(FILE_PATH_LITERAL("data")));
You can just use FILE_PATH_LITERAL("content/test/data") here

[Takashi Toyoshima, 2012-10-11 03:55:36]

OK, thanks.
I'll push this into CQ.

https://codereview.chromium.org/11094040/diff/1/chrome/test/base/in_process_b...
File chrome/test/base/in_process_browser_test.cc (right):

https://codereview.chromium.org/11094040/diff/1/chrome/test/base/in_process_b...
chrome/test/base/in_process_browser_test.cc:84:
.Append(FILE_PATH_LITERAL("data")));
On 2012/10/10 17:38:40, Ryan Sleevi wrote:
> FILE_PATH_LITERAL("chrome/test/data") ?

Done.

https://codereview.chromium.org/11094040/diff/1/content/test/content_browser_...
File content/test/content_browser_test.cc (right):

https://codereview.chromium.org/11094040/diff/1/content/test/content_browser_...
content/test/content_browser_test.cc:46: .Append(FILE_PATH_LITERAL("data")));
On 2012/10/10 17:38:40, Ryan Sleevi wrote:
> You can just use FILE_PATH_LITERAL("content/test/data") here

Done.

[commit-bot: I haz the power, 2012-10-11 03:55:55]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/toyoshim@chromium.org/11094040/10001

[commit-bot: I haz the power, 2012-10-11 06:45:02]

Retried try job too often for step(s) browser_tests

[commit-bot: I haz the power, 2012-10-11 07:03:11]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/toyoshim@chromium.org/11094040/10001

[commit-bot: I haz the power, 2012-10-11 08:56:12]

Change committed as 161318