gcl.py - Issue 11094033: Make repos without VIEW_VC also post Committed to the codereview.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: gcl.py

Issue 11094033: Make repos without VIEW_VC also post Committed to the codereview. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/tools/depot_tools

Patch Set: Created 8 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: gcl.py

diff --git a/gcl.py b/gcl.py

index 750e4cabb41eed4f872bbc5d0dd9d188ef579b17..d043a35035481d0d18299ba0b6d8488917f65eea 100755

--- a/gcl.py

+++ b/gcl.py

@@ -1033,8 +1033,10 @@ def CMDcommit(change_info, args):

re.DOTALL).match(output).group(1)

viewvc_url = gclient_utils.UpgradeToHttps(GetCodeReviewSetting('VIEW_VC'))

change_info.description += '\n'

- if viewvc_url:

+ if viewvc_url and revision:

change_info.description += "\nCommitted: " + viewvc_url + revision

+ elif revision:

+ change_info.description += "\nCommitted: " + revision

change_info.CloseIssue()

return 0

« no previous file with comments | « no previous file | git_cl.py » ('j') | no next file with comments »