content/browser/browser_plugin/browser_plugin_embedder.h - Issue 11093080: <webview>: First stab at implementing media permission request for guests.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/browser_plugin/browser_plugin_embedder.h

Issue 11093080: <webview>: First stab at implementing media permission request for guests. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Implement first allow/deny wins, still requires preventDefault impl + now tests pass. Created 7 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/renderer/resources/extensions/web_view.js ('K') | « chrome/test/data/extensions/platform_apps/web_view/media_access/media_access_guest.html ('k') | content/browser/browser_plugin/browser_plugin_embedder.cc » ('j') | content/browser/browser_plugin/browser_plugin_embedder.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/browser_plugin/browser_plugin_embedder.h

diff --git a/content/browser/browser_plugin/browser_plugin_embedder.h b/content/browser/browser_plugin/browser_plugin_embedder.h

index b8450070f171e9a4aa3d27813860789e82f3680d..9ae6adc9d6008d53b8c75b9a6a1c55fb5d0174d5 100644

--- a/content/browser/browser_plugin/browser_plugin_embedder.h

+++ b/content/browser/browser_plugin/browser_plugin_embedder.h

@@ -126,6 +126,7 @@ class CONTENT_EXPORT BrowserPluginEmbedder : public WebContentsObserver,

int request_id,

const gfx::Point& position);

void OnPluginDestroyed(int instance_id);

+ void OnAllowMediaAccess(int instance_id, int request_id, bool should_allow);

void OnSwapBuffersACK(int route_id,

int gpu_host_id,

const std::string& mailbox_name,