Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(32)

Unified Diff: chrome/renderer/resources/extensions/web_view.js

Issue 11093080: <webview>: First stab at implementing media permission request for guests. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Implement first allow/deny wins, still requires preventDefault impl + now tests pass. Created 7 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/renderer/resources/extensions/web_view.js
diff --git a/chrome/renderer/resources/extensions/web_view.js b/chrome/renderer/resources/extensions/web_view.js
index 68bd3dab8197c30c04aca2bccf588300c484a0e1..86589ea3be5b42ebcc9b356934b8cb6b98ffa913 100644
--- a/chrome/renderer/resources/extensions/web_view.js
+++ b/chrome/renderer/resources/extensions/web_view.js
@@ -129,6 +129,7 @@ function WebView(node) {
for (var eventName in WEB_VIEW_EVENTS) {
this.setupEvent_(eventName, WEB_VIEW_EVENTS[eventName]);
}
+ this.maybeSetupPermissionEvent_();
}
/**
@@ -164,7 +165,7 @@ WebView.prototype.handleObjectMutation_ = function(mutation) {
/**
* @private
*/
-WebView.prototype.setupEvent_ = function(eventname, attribs) {
+WebView.prototype.setupEvent_ = function(eventname, attribs, opt_prepareEvent) {
var node = this.node_;
this.objectNode_.addEventListener('-internal-' + eventname, function(e) {
var evt = new Event(eventname, { bubbles: true });
@@ -172,6 +173,17 @@ WebView.prototype.setupEvent_ = function(eventname, attribs) {
attribs.forEach(function(attribName) {
evt[attribName] = detail[attribName];
});
+ if (opt_prepareEvent) {
+ opt_prepareEvent(evt, detail);
+ }
node.dispatchEvent(evt);
Fady Samuel 2013/02/05 17:53:27 If true then we can deny... because preventDefault
lazyboy 2013/02/07 04:38:42 Updated CL.
});
-}
+};
+
+/**
+ * Implemented when experimental permission is available.
+ * @private
+ */
+WebView.prototype.maybeSetupPermissionEvent_ = function() {};
+
+exports.WebView = WebView;

Powered by Google App Engine
This is Rietveld 408576698