<webview>: First stab at implementing media permission request for guests.

content/renderer/browser_plugin/browser_plugin_bindings.cc

Index: content/renderer/browser_plugin/browser_plugin_bindings.cc
diff --git a/content/renderer/browser_plugin/browser_plugin_bindings.cc b/content/renderer/browser_plugin/browser_plugin_bindings.cc
index 2bf0387fe1f25c8b4d64758759bdc5ca61564800..9e3e052594b7be4374df72ae43a930b900f393af 100644
--- a/content/renderer/browser_plugin/browser_plugin_bindings.cc
+++ b/content/renderer/browser_plugin/browser_plugin_bindings.cc
@@ -44,6 +44,7 @@ const char kMethodForward[] = "forward";
 const char kMethodGetProcessId[] = "getProcessId";
 const char kMethodGo[] = "go";
 const char kMethodReload[] = "reload";
+const char kMethodSetMediaPermission[] = "setMediaPermission";

[Charlie Reis, 2012/12/07 19:16:25]

What is this for?  I don't remember it in the API discussions.

If this is just an implementation detail, can it be hidden from actual pages? 
Seems like it would allow bypassing the listeners.

[lazyboy, 2012/12/07 22:50:44]

This is just an impl details, right. It is only exposed in the <object>, not the
<webview> tag.

I'm tyring to think what kind of (unexpected) bypassing might happen even if
this somehow gets exposed... Do you have a case where this can trigger
unexpected allow/deny?

[Charlie Reis, 2012/12/17 22:28:09]

It certainly looks like the embedder could call
someObjectTag.setMediaPermission(42, true) to bypass the existing event
listeners, if it could guess the request_id (e.g., 42).  That would defeat app
developers who try to install security policies to restrict their own app's
behavior, which isn't ok.

[Fady Samuel, 2013/02/05 17:53:26]

This is not forwarded from the shim to the BrowserPlugin.

 const char kMethodStop[] = "stop";
 const char kMethodTerminate[] = "terminate";
 
@@ -369,6 +370,26 @@ class BrowserPluginBindingStop : public BrowserPluginMethodBinding {
   DISALLOW_COPY_AND_ASSIGN(BrowserPluginBindingStop);
 };
 
+class BrowserPluginBindingSetMediaPermission
+    : public BrowserPluginMethodBinding {
+ public:
+  BrowserPluginBindingSetMediaPermission()
+      : BrowserPluginMethodBinding(kMethodSetMediaPermission, 2) {
+  }
+
+  virtual bool Invoke(BrowserPluginBindings* bindings,
+                      const NPVariant* args,
+                      NPVariant* result) OVERRIDE {
+    int request_id = Int32FromNPVariant(args[0]);
+    bool allow = NPVARIANT_TO_BOOLEAN(args[1]);
+    bindings->instance()->RespondMediaAccess(request_id, allow);
+    return true;
+  }
+
+ private:
+  DISALLOW_COPY_AND_ASSIGN(BrowserPluginBindingSetMediaPermission);
+};
+
 class BrowserPluginBindingTerminate : public BrowserPluginMethodBinding {
  public:
   BrowserPluginBindingTerminate()
@@ -663,6 +684,7 @@ BrowserPluginBindings::BrowserPluginBindings(BrowserPlugin* instance)
   method_bindings_.push_back(new BrowserPluginBindingGetProcessID);
   method_bindings_.push_back(new BrowserPluginBindingGo);
   method_bindings_.push_back(new BrowserPluginBindingReload);
+  method_bindings_.push_back(new BrowserPluginBindingSetMediaPermission);
   method_bindings_.push_back(new BrowserPluginBindingStop);
   method_bindings_.push_back(new BrowserPluginBindingTerminate);