chrome/renderer/extensions/dispatcher.cc - Issue 11093080: <webview>: First stab at implementing media permission request for guests.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/renderer/extensions/dispatcher.cc

Issue 11093080: <webview>: First stab at implementing media permission request for guests. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Add todo for auto deny when no listeners attached. Created 8 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/common/extensions/permissions/api_permission.h ('K') | « chrome/common/extensions/permissions/api_permission.cc ('k') | chrome/renderer/resources/extensions/web_view.js » ('j') | chrome/renderer/resources/extensions/web_view_permission_api.js » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/renderer/extensions/dispatcher.cc

diff --git a/chrome/renderer/extensions/dispatcher.cc b/chrome/renderer/extensions/dispatcher.cc

index 29523ddfe24eab5652ae7ed4a4beb90ccadbf19d..1329814df113cd8a0fb0fed53d5824bb841c5ac7 100644

--- a/chrome/renderer/extensions/dispatcher.cc

+++ b/chrome/renderer/extensions/dispatcher.cc

@@ -679,6 +679,8 @@ void Dispatcher::PopulateSourceMap() {

// Platform app sources that are not API-specific..

source_map_.RegisterSource("webview", IDR_WEB_VIEW_JS);

+ source_map_.RegisterSource("webview.permissionAPI",

+ IDR_WEB_VIEW_PERMISSION_API_JS);

source_map_.RegisterSource("platformApp", IDR_PLATFORM_APP_JS);

source_map_.RegisterSource("injectAppTitlebar", IDR_INJECT_APP_TITLEBAR_JS);

}

@@ -812,6 +814,8 @@ void Dispatcher::DidCreateScriptContext(

if (context_type == Feature::BLESSED_EXTENSION_CONTEXT &&

extension->HasAPIPermission(APIPermission::kWebView)) {

module_system->Require("webview");

+ if (extension->HasAPIPermission(APIPermission::kWebViewPermissionAPI))

+ module_system->Require("webview.permissionAPI");

}

context->set_module_system(module_system.Pass());