<webview>: First stab at implementing media permission request for guests.

content/renderer/browser_plugin/browser_plugin.cc

Index: content/renderer/browser_plugin/browser_plugin.cc
diff --git a/content/renderer/browser_plugin/browser_plugin.cc b/content/renderer/browser_plugin/browser_plugin.cc
index 0971b85042d3ddf0e02b4bf542398285d4010c31..85851477571dde25d7f3b833eb56c125b88321df 100644
--- a/content/renderer/browser_plugin/browser_plugin.cc
+++ b/content/renderer/browser_plugin/browser_plugin.cc
@@ -26,8 +26,8 @@
 #include "third_party/WebKit/Source/WebKit/chromium/public/WebInputEvent.h"
 #include "third_party/WebKit/Source/WebKit/chromium/public/WebPluginContainer.h"
 #include "third_party/WebKit/Source/WebKit/chromium/public/WebPluginParams.h"
-#include "third_party/WebKit/Source/WebKit/chromium/public/platform/WebRect.h"
 #include "third_party/WebKit/Source/WebKit/chromium/public/WebScriptSource.h"
+#include "third_party/WebKit/Source/WebKit/chromium/public/platform/WebRect.h"
 #include "webkit/plugins/sad_plugin.h"
 
 #if defined (OS_WIN)
@@ -59,8 +59,11 @@ const char kOldURL[] = "oldUrl";
 const char kOldHeight[] = "oldHeight";
 const char kOldWidth[] = "oldWidth";
 const char kPartitionAttribute[] = "partition";
+const char kPermissionRequestEventName[] = "permissionrequest";

[sadrul, 2012/11/16 03:59:53]

General comment (definitely not scope for this CL): the event names and the
attrib names are inter-mingled here. It is difficult to get the list of events
at a glance. It would be good to list the event names and the various attrib
names separately.

[lazyboy, 2012/11/16 06:27:09]

Agreed, I'll fix that separately so I don't have to worry abt merge conflicts in
this CL.

+const char kPermissionTypeMedia[] = "media";
 const char kPersistPrefix[] = "persist:";
 const char kProcessId[] = "processId";
+const char kRequestIdKey[] = "request_id";
 const char kSizeChangedEventName[] = "sizechanged";
 const char kSrcAttribute[] = "src";
 const char kReason[] = "reason";
@@ -587,6 +590,13 @@ void BrowserPlugin::LoadAbort(const GURL& url,
   TriggerEvent(kLoadAbortEventName, &props);
 }
 
+void BrowserPlugin::RequestMediaAccess(int request_id) {
+  std::map<std::string, base::Value*> props;
+  props[kReason] = base::Value::CreateStringValue(kPermissionTypeMedia);
+  props[kRequestIdKey] = base::Value::CreateIntegerValue(request_id);
+  TriggerEvent(kPermissionRequestEventName, &props);
+}
+
 void BrowserPlugin::LoadRedirect(const GURL& old_url,
                                  const GURL& new_url,
                                  bool is_top_level) {
@@ -637,6 +647,14 @@ void BrowserPlugin::SetAcceptTouchEvents(bool accept) {
     container()->setIsAcceptingTouchEvents(accept);
 }
 
+void BrowserPlugin::AllowMediaAccess(int request_id, bool allow) {
+  BrowserPluginManager::Get()->Send(
+      new BrowserPluginHostMsg_AllowMediaAccess(render_view_->GetRoutingID(),
+                                                instance_id_,
+                                                request_id,
+                                                allow));
+}
+
 WebKit::WebPluginContainer* BrowserPlugin::container() const {
   return container_;
 }