<webview>: First stab at implementing media permission request for guests.

chrome/renderer/resources/extensions/web_view.js

Index: chrome/renderer/resources/extensions/web_view.js
diff --git a/chrome/renderer/resources/extensions/web_view.js b/chrome/renderer/resources/extensions/web_view.js
index 13331c49bc21b843e98bdd4699766c430f39df3c..335a2887bdee048b3282fa1839ebd86ee4aee923 100644
--- a/chrome/renderer/resources/extensions/web_view.js
+++ b/chrome/renderer/resources/extensions/web_view.js
@@ -123,6 +123,34 @@ function WebView(node) {
   for (var eventName in WEB_VIEW_EVENTS) {
     this.setupEvent_(eventName, WEB_VIEW_EVENTS[eventName]);
   }
+  this.setupPermissionRequestEvent_();
+}
+
+/**
+ * @private
+ */
+WebView.prototype.setupPermissionRequestEvent_ = function(mutation) {

[sadrul, 2012/11/16 03:59:53]

Can setupEvent_ be reused for this? setupEvent_ can take an optional third param
which is a callback that prepares the events. For example:

   setupEvent_('permissionrequest', ['reason', ...], prepareEvent);

where prepareEvent is a function:

   function prepareEvent(custom_event, webview_event) {
     if (/* custom_event.request_id is not undefined */) {
       webview_event.reason = custom_event.reason;
       webview_event.allow = ...;
       webview_event.deny = ...;
     }
   }

and setupEvent_ will call into this just before it dispatches the event.

The reason I am proposing this is that the internal details of the event
dispatching from the <object> plugin to the <webview> shim can change (e.g. we
decide at some future time that this custom event business is not what we want,
and we use postMessage or some other mechanism for this). So the main code that
dispatches the event to the <webview> consumers happens in a single place.

[lazyboy, 2012/11/16 06:27:09]

Yes that makes sense.
Done.

+  var node = this.node_;
+  var objectNode = this.objectNode_;
+  this.objectNode_.addEventListener('-internal-permissionrequest', function(e) {
+    var detail = e.detail ? JSON.parse(e.detail) : {};
+    if (detail.reason == 'media') {
+      var request_id = detail.request_id;
+      if (request_id !== undefined) {
+        var evt = new Event('permissionrequest');
+        // TODO(lazyboy): Also fill in evt.url and evt.details (see webview
+        // specs).
+        evt.reason = detail.reason;
+        evt.allow = function() {
+          objectNode.setMediaPermission(request_id, true /* allow */);
+        };
+        evt.deny = function() {
+          objectNode.setMediaPermission(request_id, false /* allow */);

[Fady Samuel, 2012/11/16 03:42:59]

This looks good. Looks like what we discussed.

+        }
+        node.dispatchEvent(evt);
+      }
+    }
+  });
 };
 
 /**