content/renderer/browser_plugin/browser_plugin.h - Issue 11093080: <webview>: First stab at implementing media permission request for guests.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/renderer/browser_plugin/browser_plugin.h

Issue 11093080: <webview>: First stab at implementing media permission request for guests. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Address comments from fsamuel@ Created 8 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« content/common/browser_plugin_messages.h ('K') | « content/common/browser_plugin_messages.h ('k') | content/renderer/browser_plugin/browser_plugin.cc » ('j') | content/renderer/browser_plugin/browser_plugin.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/renderer/browser_plugin/browser_plugin.h

diff --git a/content/renderer/browser_plugin/browser_plugin.h b/content/renderer/browser_plugin/browser_plugin.h

index 45ae96d09a691c0183cc628fcfa455306bd19031..e2da4398d3a65b0e6b14db6ca2d38f613caffa14 100644

--- a/content/renderer/browser_plugin/browser_plugin.h

+++ b/content/renderer/browser_plugin/browser_plugin.h

@@ -70,6 +70,12 @@ class CONTENT_EXPORT BrowserPlugin :

// touch events.

void SetAcceptTouchEvents(bool accept);

+ // Requests the embedder (browser process) for media access permission.

Charlie Reis 2012/10/17 06:18:45 nit: Requests media access permission from the emb

lazyboy 2012/10/17 09:09:53 Done.

+ void RequestMediaAccess(int request_id);

+ // Informs the BrowserPlugin that the guest's request to media access has been

Charlie Reis 2012/10/17 06:18:45 Heh, in this case you do want "for" rather than "t

lazyboy 2012/10/17 09:09:53 Done.

+ // allowed or denied.

+ void AllowMediaAccess(int request_id, bool allow);

// Indicates whether there are any Javascript listeners attached to a

// provided event_name.

bool HasListeners(const std::string& event_name);