Issue 11093072: Removing the reference to the 'commands' permission as it is no longer needed.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 11093072: Removing the reference to the 'commands' permission as it is no longer needed. (Closed)

Created:
8 years, 2 months ago by Finnur

Modified:
8 years, 2 months ago

Reviewers:
Mihai Parparita -not on Chrome

CC:
chromium-reviews, Aaron Boodman, mihaip-chromium-reviews_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src/

Visibility:
Public.

More Reviews

Description

Removing the reference to the 'commands' permission as it is no longer needed. BUG=153178 TEST=The docs should no longer show the 'commands' permission as being a pre-requisite. Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=161341

Patch Set 1 #

Total comments: 1

Created: 8 years, 2 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -11 lines)			Patch
	M	chrome/common/extensions/docs/templates/intros/commands.html	View		1 chunk	+1 line, -11 lines	1 comment	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Mihai Parparita -not on Chrome

LGTM https://chromiumcodereview.appspot.com/11093072/diff/1/chrome/common/extensions/docs/templates/intros/commands.html File chrome/common/extensions/docs/templates/intros/commands.html (right): https://chromiumcodereview.appspot.com/11093072/diff/1/chrome/common/extensions/docs/templates/intros/commands.html#newcode17 chrome/common/extensions/docs/templates/intros/commands.html:17: AltGr key.</p> The change to the old docs ...

8 years, 2 months ago (2012-10-11 14:12:42 UTC) #2

Good catch. Will fix.

Expand Messages | Collapse Messages