Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(368)

Issue 11093059: Use blocking worker pool for sync file operations in Pepper. (Closed)

Created:
8 years, 2 months ago by Scott Hess - ex-Googler
Modified:
8 years, 2 months ago
Reviewers:
brettw, yzshen1
CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, jam
Visibility:
Public.

Description

Use blocking worker pool for sync file operations in Pepper. Switch from posting file operations on the file thread to posting them on the blocking worker pool. Previous instrumentation indicated that this reduces hung-plugin infobars by around 20%. BUG=153383 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=161459

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+17 lines, -7 lines) Patch
M content/browser/renderer_host/pepper/pepper_file_message_filter.h View 1 chunk +2 lines, -3 lines 0 comments Download
M content/browser/renderer_host/pepper/pepper_file_message_filter.cc View 2 chunks +13 lines, -4 lines 0 comments Download
M content/browser/web_contents/web_contents_impl.cc View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
Scott Hess - ex-Googler
To land after revert in https://codereview.chromium.org/11087068/ After sending a try, I realized that without the ...
8 years, 2 months ago (2012-10-10 22:47:50 UTC) #1
yzshen1
lgtm
8 years, 2 months ago (2012-10-10 22:52:29 UTC) #2
Scott Hess - ex-Googler
brettw for rubberstamp. the earlier comment refs a cl which shows final result of all ...
8 years, 2 months ago (2012-10-10 23:32:14 UTC) #3
brettw
lgtm
8 years, 2 months ago (2012-10-11 21:23:16 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/shess@chromium.org/11093059/1
8 years, 2 months ago (2012-10-11 21:27:24 UTC) #5
commit-bot: I haz the power
8 years, 2 months ago (2012-10-12 00:33:56 UTC) #6
Change committed as 161459

Powered by Google App Engine
This is Rietveld 408576698