Issue 11092081: Reland r12342: Flush monomorphic ICs on context disposal instead of context exit.

Issue 11092081: Reland r12342: Flush monomorphic ICs on context disposal instead of context exit. (Closed)

Created:
8 years, 2 months ago by ulan

Modified:
8 years, 2 months ago

Reviewers:
Michael Starzinger

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

More Reviews

Description

Reland r12342: Flush monomorphic ICs on context disposal instead of context exit. The crashes that caused r12342 to be reverted are fixed in r12563. R=mstarzinger@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=12715

Patch Set 1 #

Total comments: 6

Patch Set 2 : Address comments #

Created: 8 years, 2 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+34 lines, -16 lines)			Patch
M	src/heap.h	View		3 chunks	+8 lines, -1 line	0 comments	Download
	src/heap.cc	View		2 chunks	+2 lines, -1 line	0 comments	Download
M	src/objects-visiting-inl.h	View		1 chunk	+2 lines, -3 lines	0 comments	Download
M	test/cctest/test-api.cc	View	1	3 chunks	+5 lines, -0 lines	0 comments	Download
	test/cctest/test-heap.cc	View		6 chunks	+5 lines, -2 lines	0 comments	Download
	test/mjsunit/debug-script.js	View	1	1 chunk	+4 lines, -2 lines	0 comments	Download
M	test/mjsunit/elements-transition-hoisting.js	View		9 chunks	+8 lines, -7 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Michael Starzinger

LGTM (with a few nits). https://codereview.chromium.org/11092081/diff/1/test/cctest/test-api.cc File test/cctest/test-api.cc (right): https://codereview.chromium.org/11092081/diff/1/test/cctest/test-api.cc#newcode2 test/cctest/test-api.cc:2: That looks like a ...

8 years, 2 months ago (2012-10-12 11:08:07 UTC) #2

ulan

8 years, 2 months ago (2012-10-12 12:23:09 UTC) #3

Addressed comments, landing.

https://codereview.chromium.org/11092081/diff/1/test/cctest/test-api.cc
File test/cctest/test-api.cc (right):

https://codereview.chromium.org/11092081/diff/1/test/cctest/test-api.cc#newcode2
test/cctest/test-api.cc:2: 
On 2012/10/12 11:08:07, Michael Starzinger wrote:
> That looks like a typo?

Done.

https://codereview.chromium.org/11092081/diff/1/test/cctest/test-api.cc#newco...
test/cctest/test-api.cc:10844: // Fire context disposed notification to force
clearing monomorphic ICs.
On 2012/10/12 11:08:07, Michael Starzinger wrote:
> I think we can drop the comment, the method call itself should be
> self-explanatory. Same for the rest of the function.

Done.

https://codereview.chromium.org/11092081/diff/1/test/mjsunit/debug-script.js
File test/mjsunit/debug-script.js (right):

https://codereview.chromium.org/11092081/diff/1/test/mjsunit/debug-script.js#...
test/mjsunit/debug-script.js:29: // Flags: --send-idle-notification
On 2012/10/12 11:08:07, Michael Starzinger wrote:
> Add empty newline after the second "// Flags" comment.

Done.

Expand Messages | Collapse Messages