Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(959)

Unified Diff: chrome/browser/chromeos/extensions/wallpaper_private_api.h

Issue 11092078: Add some error messages for setting wallpaper failures on Chrome(c++) side. (Closed) Base URL: http://git.chromium.org/chromium/src.git@master
Patch Set: Using localized string Created 8 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/chromeos/extensions/wallpaper_private_api.h
diff --git a/chrome/browser/chromeos/extensions/wallpaper_private_api.h b/chrome/browser/chromeos/extensions/wallpaper_private_api.h
index 51459db513af47f6a01cd6c378eb2eb0a0a6210a..d781710e04d251fd91d42505bf44205f4a7a2f62 100644
--- a/chrome/browser/chromeos/extensions/wallpaper_private_api.h
+++ b/chrome/browser/chromeos/extensions/wallpaper_private_api.h
@@ -37,9 +37,11 @@ class WallpaperFunctionBase : public AsyncExtensionFunction {
// Holds an instance of WallpaperDecoder.
static WallpaperDecoder* wallpaper_decoder_;
+ // Handles failure or cancel cases. Passes error message to Javascript side.
+ void OnFailureOrCancel(const std::string& error);
+
private:
virtual void OnWallpaperDecoded(const gfx::ImageSkia& wallpaper) = 0;
- virtual void OnFailureOrCancel() = 0;
};
class WallpaperSetWallpaperFunction : public WallpaperFunctionBase {
@@ -56,7 +58,6 @@ class WallpaperSetWallpaperFunction : public WallpaperFunctionBase {
private:
virtual void OnWallpaperDecoded(const gfx::ImageSkia& wallpaper) OVERRIDE;
- virtual void OnFailureOrCancel() OVERRIDE;
// Saves the image data to a file.
void SaveToFile();
@@ -94,7 +95,6 @@ class WallpaperSetCustomWallpaperFunction : public WallpaperFunctionBase {
private:
virtual void OnWallpaperDecoded(const gfx::ImageSkia& wallpaper) OVERRIDE;
- virtual void OnFailureOrCancel() OVERRIDE;
// Layout of the downloaded wallpaper.
ash::WallpaperLayout layout_;

Powered by Google App Engine
This is Rietveld 408576698