Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1030)

Unified Diff: content/browser/browser_plugin/browser_plugin_guest.cc

Issue 11092023: Browser Plugin: Implement CanGoBack/CanGoForward (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Addressed creis@'s comments Created 8 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | content/browser/browser_plugin/browser_plugin_host_browsertest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/browser/browser_plugin/browser_plugin_guest.cc
diff --git a/content/browser/browser_plugin/browser_plugin_guest.cc b/content/browser/browser_plugin/browser_plugin_guest.cc
index d470801eb6667279c79734097e1488e0357222c4..e225583313daeee33359194c7b2ccc9247f07a7d 100644
--- a/content/browser/browser_plugin/browser_plugin_guest.cc
+++ b/content/browser/browser_plugin/browser_plugin_guest.cc
@@ -383,14 +383,17 @@ void BrowserPluginGuest::DidCommitProvisionalLoadForFrame(
PageTransition transition_type,
RenderViewHost* render_view_host) {
// Inform its embedder of the updated URL.
- if (is_main_frame) {
- SendMessageToEmbedder(
- new BrowserPluginMsg_DidNavigate(
- instance_id(),
- url,
- render_view_host->GetProcess()->GetID()));
- RecordAction(UserMetricsAction("BrowserPlugin.Guest.DidNavigate"));
- }
+ BrowserPluginMsg_DidNavigate_Params params;
+ params.url = url;
+ params.is_top_level = is_main_frame;
+ params.process_id = render_view_host->GetProcess()->GetID();
+ params.current_entry_index =
+ web_contents()->GetController().GetCurrentEntryIndex();
+ params.entry_count =
+ web_contents()->GetController().GetEntryCount();
+ SendMessageToEmbedder(
+ new BrowserPluginMsg_DidNavigate(instance_id(), params));
+ RecordAction(UserMetricsAction("BrowserPlugin.Guest.DidNavigate"));
}
void BrowserPluginGuest::RenderViewGone(base::TerminationStatus status) {
« no previous file with comments | « no previous file | content/browser/browser_plugin/browser_plugin_host_browsertest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698