crypto: remove unused Mac SignatureVerifier.

crypto: remove unused Mac SignatureVerifier.


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=160892

[agl, 2012-10-08 20:57:43]

This code appears to be unused and uncompiled. Ok to remove?

[Ryan Sleevi, 2012-10-08 21:34:01]

I suspect we should also remove encryptor_mac, hmac_mac, symmetric_key_mac, and
encryptor_win (following http://crrev.com/142356 ). The remaining _win files are
still used for NACL Win64.

http://crrev.com/118964 is what nuked the Win & Mac signature_verifier files. As
mentioned on the CL at the time, it was not clear to me whether or not we wanted
to commit to moving to a "pure NSS or OpenSSL" system. We've continued to move
towards that, as it relates to media and as it will (presumably) relate to Web
Crypto API, so perhaps now is the time to cut the native implementations.

I think this LGTM, but I'm not sure if Wan-Teh wants to keep them around for the
same reason we keep the system SSL stuff around (which admittedly, compiles, but
is not tested)

[wtc, 2012-10-09 01:10:47]

Patch set 1 LGTM. Please also remove crypto/signature_verifier_win.cc.

crypto/signature_verifier_{mac,win}.cc are worth keeping
if they are being used. But their class members have already
been removed from crypto/signature_verifier.h, so they can't
even be compiled right now.

[commit-bot: I haz the power, 2012-10-09 17:32:30]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/agl@chromium.org/11092006/4002

[commit-bot: I haz the power, 2012-10-09 19:22:43]

Change committed as 160892