Ifdef out the parts of navigation_controller.h that are not supported on iOS.

Ifdef out the parts of navigation_controller.h that are not supported on iOS.


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=161329

[msarda, 2012-10-08 14:57:09]

PTAL.

[stuartmorgan, 2012-10-08 14:59:32]

LGTM
+jam for OWNERS
As I think we've discussed briefly, we have a navigation controller
implementation, and sharing the header lets us share a bunch of other code.

[stuartmorgan, 2012-10-08 15:01:30]

+jam for real (see previous comment). Someday I'll learn to update the revier
list first so I stop making this mistake :P

[jam, 2012-10-10 04:03:29]

lgtm

[jam, 2012-10-10 04:04:18]

actually, shouldn't this also involve changes to navigation_controller_impl.*?

[stuartmorgan, 2012-10-10 05:39:38]

On 2012/10/10 04:04:18, John Abd-El-Malek wrote:
> actually, shouldn't this also involve changes to navigation_controller_impl.*?

We don't yet use the same implementation; we hope to get there, but in the mean
time having a different class that implements the interface makes using a lot of
other code easier.

[jam, 2012-10-11 00:19:19]

On 2012/10/10 05:39:38, stuartmorgan wrote:
> On 2012/10/10 04:04:18, John Abd-El-Malek wrote:
> > actually, shouldn't this also involve changes to
navigation_controller_impl.*?
> 
> We don't yet use the same implementation; we hope to get there, but in the
mean
> time having a different class that implements the interface makes using a lot
of
> other code easier.

i see, ok, slgtm

[commit-bot: I haz the power, 2012-10-11 09:17:32]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/msarda@chromium.org/11092005/1

[commit-bot: I haz the power, 2012-10-11 11:54:45]

Change committed as 161329