Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(64)

Issue 11091072: Fix failing browser tests when running with force-compositing-mode. It uses new trace events checke… (Closed)

Created:
8 years, 2 months ago by Vangelis Kokkevis
Modified:
8 years, 2 months ago
CC:
chromium-reviews, mihaip-chromium-reviews_chromium.org, yoshiki+watch_chromium.org, jam, apatrick_chromium, joi+watch-content_chromium.org, Aaron Boodman, darin-cc_chromium.org
Base URL:
http://git.chromium.org/chromium/src.git@master
Visibility:
Public.

Description

Fix failing browser tests when running with force-compositing-mode. It uses new trace events checked in by: http://trac.webkit.org/changeset/128785 to properly track WebGL and accelerated canvas instead of relying on the swap-buffers calls (which get issued anyway, when in FCM). This patch has most of the contents of: https://codereview.chromium.org/10914247 except that it doesn't change any of the field trial probabilities. It fixes the following tests: Canvas2DDisabled, Canvas2DBlocked, WebGLBLocked, WebGLDisabled, AcceleratedCompositingDisabled, AcceleratedCompositingBlocked . It also disables ExtensionApiTest.CaptureVisibleTabJPeg as it triggers flakiness on it. chrome.tabs.captureVisibleTab is inherently racy as there is no way to guarantee that the tab has been painted at least once when that call is made. Note how the other variants of CaptureVisibleTab tests have already been disabled for similar reasons. (this was done with aa@'s advice) BUG=155336 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=161733

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+81 lines, -39 lines) Patch
M chrome/browser/chrome_gpu_util.cc View 1 2 chunks +20 lines, -2 lines 0 comments Download
M chrome/browser/extensions/extension_tabs_apitest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/task_manager/task_manager_browsertest.cc View 1 chunk +5 lines, -3 lines 0 comments Download
M chrome/test/gpu/gpu_feature_browsertest.cc View 14 chunks +40 lines, -29 lines 0 comments Download
M content/common/compositor_util.cc View 1 2 chunks +15 lines, -4 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
Vangelis Kokkevis
This code was essentially LGTM'd in https://codereview.chromium.org/10914247 I'm now splitting the part that fixes the ...
8 years, 2 months ago (2012-10-11 23:42:15 UTC) #1
darin (slow to review)
LGTM
8 years, 2 months ago (2012-10-12 22:17:10 UTC) #2
Vangelis Kokkevis
On 2012/10/12 22:17:10, darin wrote: > LGTM Pretty sure the chrome_frame_test failures are not mine. ...
8 years, 2 months ago (2012-10-12 23:34:34 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/vangelis@chromium.org/11091072/2001
8 years, 2 months ago (2012-10-12 23:35:01 UTC) #4
commit-bot: I haz the power
8 years, 2 months ago (2012-10-13 06:06:02 UTC) #5
Change committed as 161733

Powered by Google App Engine
This is Rietveld 408576698