Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(979)

Issue 11091056: Fix up base/bind documentation - elaborate on reference binding. (Closed)

Created:
8 years, 2 months ago by groby-ooo-7-16
Modified:
8 years, 2 months ago
Reviewers:
awong
CC:
chromium-reviews, erikwright+watch_chromium.org, willchan no longer on Chromium
Visibility:
Public.

Description

Fix up base/bind documentation - elaborate on reference binding. TBR=willchan@chromium.org R=ajwong@chromium.org BUG= Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=161287

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M base/callback.h View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 9 (0 generated)
groby-ooo-7-16
Addressing your feedback from a previous CL
8 years, 2 months ago (2012-10-11 00:09:00 UTC) #1
awong
LGTM
8 years, 2 months ago (2012-10-11 00:09:46 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/groby@chromium.org/11091056/1
8 years, 2 months ago (2012-10-11 00:15:04 UTC) #3
commit-bot: I haz the power
Presubmit check for 11091056-1 failed and returned exit status 1. Running presubmit commit checks ...
8 years, 2 months ago (2012-10-11 00:15:07 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/groby@chromium.org/11091056/1
8 years, 2 months ago (2012-10-11 00:17:45 UTC) #5
willchan no longer on Chromium
Lgtm On Oct 10, 2012 5:17 PM, <commit-bot@chromium.org> wrote: > CQ is trying da patch. ...
8 years, 2 months ago (2012-10-11 01:24:36 UTC) #6
commit-bot: I haz the power
Retried try job too often for step(s) browser_tests
8 years, 2 months ago (2012-10-11 02:52:17 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/groby@chromium.org/11091056/1
8 years, 2 months ago (2012-10-11 03:05:02 UTC) #8
commit-bot: I haz the power
8 years, 2 months ago (2012-10-11 03:54:34 UTC) #9
Change committed as 161287

Powered by Google App Engine
This is Rietveld 408576698