Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(156)

Issue 11091048: Add helper function to test that a given URL is a valid Gaia sign in URL. (Closed)

Created:
8 years, 2 months ago by Roger Tawa OOO till Jul 10th
Modified:
8 years, 2 months ago
Reviewers:
Jói
CC:
chromium-reviews
Visibility:
Public.

Description

Add helper function to test that a given URL is a valid Gaia sign in URL. BUG=137118 TEST=See unit tests, not called in any code yet Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=161282

Patch Set 1 #

Patch Set 2 : rebased #

Patch Set 3 : rebased #

Unified diffs Side-by-side diffs Delta from patch set Stats (+31 lines, -0 lines) Patch
M google_apis/gaia/gaia_auth_util.h View 2 chunks +4 lines, -0 lines 0 comments Download
M google_apis/gaia/gaia_auth_util.cc View 2 chunks +11 lines, -0 lines 0 comments Download
M google_apis/gaia/gaia_auth_util_unittest.cc View 2 chunks +16 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Roger Tawa OOO till Jul 10th
Hi Joi, Please take a look. Thanks.
8 years, 2 months ago (2012-10-10 19:48:31 UTC) #1
Jói
LGTM
8 years, 2 months ago (2012-10-10 21:25:35 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rogerta@chromium.org/11091048/4001
8 years, 2 months ago (2012-10-11 01:57:58 UTC) #3
commit-bot: I haz the power
8 years, 2 months ago (2012-10-11 03:20:30 UTC) #4
Change committed as 161282

Powered by Google App Engine
This is Rietveld 408576698