Issue 11091042: Converted GetOriginsForHostTask to use base::PostTaskAndReply(). Deleted superclasses GetOriginsTas…

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 11091042: Converted GetOriginsForHostTask to use base::PostTaskAndReply(). Deleted superclasses GetOriginsTas… (Closed)

Created:
8 years, 2 months ago by calvinlo

Modified:
8 years, 2 months ago

Reviewers:
kinuko, michaeln, dgrogan

CC:
chromium-reviews, joi+watch-content_chromium.org, jam, darin-cc_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Converted GetOriginsForHostTask to use base::PostTaskAndReply(). Deleted superclasses GetOriginsTaskBase, HelperTask. Also deleted QuotaTaskThread class as nothing references that anymore. BUG=139270 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=161307

Patch Set 1 #

Created: 8 years, 2 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+25 lines, -196 lines)			Patch
M	content/browser/in_process_webkit/indexed_db_quota_client.h	View	1 chunk	+0 lines, -16 lines	0 comments	Download
M	content/browser/in_process_webkit/indexed_db_quota_client.cc	View	5 chunks	+25 lines, -84 lines	0 comments	Download
M	webkit/quota/quota_task.h	View	3 chunks	+0 lines, -39 lines	0 comments	Download
M	webkit/quota/quota_task.cc	View	1 chunk	+0 lines, -34 lines	0 comments	Download
M	webkit/quota/quota_types.h	View	1 chunk	+0 lines, -23 lines	0 comments	Download

Messages

Total messages: 6 (0 generated)

Expand Messages | Collapse Messages

calvinlo

I believe this should be the last of the QuotaTaskThread cleanup patches.

8 years, 2 months ago (2012-10-10 08:55:55 UTC) #1

kinuko

lgtm for webkit/quota indexeddb change also looks good but deferring the decision to the owners.

8 years, 2 months ago (2012-10-10 10:30:52 UTC) #2

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/calvinlo@chromium.org/11091042/1

8 years, 2 months ago (2012-10-11 04:45:55 UTC) #5

Change committed as 161307

Expand Messages | Collapse Messages