Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(236)

Issue 11090082: Move PerfTest TraceEvent to async (Closed)

Created:
8 years, 2 months ago by David Trainor- moved to gerrit
Modified:
8 years, 2 months ago
CC:
chromium-reviews, jam, joi+watch-content_chromium.org, bulach+watch_chromium.org, yfriedman+watch_chromium.org, darin-cc_chromium.org, peter+watch_chromium.org, ilevy+watch_chromium.org
Visibility:
Public.

Description

Move PerfTest TraceEvent to async Move the perf test events to use START/FINISH TraceEvent paths, which will work properly if they are not triggered in the right nested order. BUG=http://crbug.com/150584 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=161942

Patch Set 1 #

Total comments: 8

Patch Set 2 : Added comments, addressed nits #

Patch Set 3 : Resolved small comment diff from downstream #

Patch Set 4 : Fix build break #

Unified diffs Side-by-side diffs Delta from patch set Stats (+198 lines, -48 lines) Patch
M build/android/pylib/json_perf_parser.py View 2 chunks +4 lines, -4 lines 0 comments Download
M content/common/android/trace_event_binding.cc View 1 4 chunks +59 lines, -6 lines 0 comments Download
M content/public/android/java/src/org/chromium/content/common/PerfTraceEvent.java View 1 2 3 9 chunks +38 lines, -20 lines 0 comments Download
M content/public/android/java/src/org/chromium/content/common/TraceEvent.java View 1 5 chunks +97 lines, -18 lines 0 comments Download

Messages

Total messages: 14 (0 generated)
David Trainor- moved to gerrit
8 years, 2 months ago (2012-10-11 21:10:24 UTC) #1
Yaron
I don't know any of this code. Can you find someone else that's familiar with ...
8 years, 2 months ago (2012-10-11 21:51:38 UTC) #2
David Trainor- moved to gerrit
8 years, 2 months ago (2012-10-11 23:36:11 UTC) #3
David Trainor- moved to gerrit
Was LGTM'ed downstream by Grace and
8 years, 2 months ago (2012-10-11 23:38:09 UTC) #4
David Trainor- moved to gerrit
On 2012/10/11 23:38:09, dtrainor wrote: > Was LGTM'ed downstream by Grace and Xianzhu!
8 years, 2 months ago (2012-10-11 23:38:30 UTC) #5
Ted C
nits! https://chromiumcodereview.appspot.com/11090082/diff/1/content/common/android/trace_event_binding.cc File content/common/android/trace_event_binding.cc (right): https://chromiumcodereview.appspot.com/11090082/diff/1/content/common/android/trace_event_binding.cc#newcode26 content/common/android/trace_event_binding.cc:26: jname_(jname), should these be aligned with env above? ...
8 years, 2 months ago (2012-10-11 23:46:30 UTC) #6
David Trainor- moved to gerrit
Addressed nits. https://chromiumcodereview.appspot.com/11090082/diff/1/content/common/android/trace_event_binding.cc File content/common/android/trace_event_binding.cc (right): https://chromiumcodereview.appspot.com/11090082/diff/1/content/common/android/trace_event_binding.cc#newcode26 content/common/android/trace_event_binding.cc:26: jname_(jname), On 2012/10/11 23:46:30, Ted C wrote: ...
8 years, 2 months ago (2012-10-12 00:10:49 UTC) #7
Ted C
lgtm
8 years, 2 months ago (2012-10-12 00:11:15 UTC) #8
David Trainor- moved to gerrit
Yaron: Can I get the lgtm for content/public/android?
8 years, 2 months ago (2012-10-12 16:24:59 UTC) #9
Yaron
lgtm
8 years, 2 months ago (2012-10-12 16:36:24 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dtrainor@chromium.org/11090082/3004
8 years, 2 months ago (2012-10-12 22:37:04 UTC) #11
commit-bot: I haz the power
Sorry for I got bad news for ya. Compile failed with a clobber build. Your ...
8 years, 2 months ago (2012-10-12 22:57:44 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dtrainor@chromium.org/11090082/14003
8 years, 2 months ago (2012-10-15 17:48:28 UTC) #13
commit-bot: I haz the power
8 years, 2 months ago (2012-10-15 20:33:04 UTC) #14
Change committed as 161942

Powered by Google App Engine
This is Rietveld 408576698