Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1396)

Issue 11090018: Only register the newer one of {bundled, component} Pepper Flash. (Closed)

Created:
8 years, 2 months ago by Bernhard Bauer
Modified:
8 years, 2 months ago
Reviewers:
cpu_(ooo_6.6-7.5), jam
CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, jam, yzshen1
Visibility:
Public.

Description

Only register the newer one of {bundled, component} Pepper Flash. BUG=151716 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=161210

Patch Set 1 #

Total comments: 4

Patch Set 2 : review #

Unified diffs Side-by-side diffs Delta from patch set Stats (+36 lines, -0 lines) Patch
M chrome/browser/component_updater/pepper_flash_component_installer.cc View 1 2 chunks +27 lines, -0 lines 0 comments Download
M content/browser/plugin_service_impl.h View 1 chunk +2 lines, -0 lines 0 comments Download
M content/browser/plugin_service_impl.cc View 1 chunk +5 lines, -0 lines 0 comments Download
M content/public/browser/plugin_service.h View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 10 (0 generated)
Bernhard Bauer
Please review.
8 years, 2 months ago (2012-10-09 13:52:01 UTC) #1
cpu_(ooo_6.6-7.5)
http://codereview.chromium.org/11090018/diff/1/chrome/browser/component_updater/pepper_flash_component_installer.cc File chrome/browser/component_updater/pepper_flash_component_installer.cc (right): http://codereview.chromium.org/11090018/diff/1/chrome/browser/component_updater/pepper_flash_component_installer.cc#newcode169 chrome/browser/component_updater/pepper_flash_component_installer.cc:169: (plugin.pepper_permissions & ppapi::PERMISSION_FLASH); can you add a comment here ...
8 years, 2 months ago (2012-10-09 20:00:36 UTC) #2
Bernhard Bauer
http://codereview.chromium.org/11090018/diff/1/chrome/browser/component_updater/pepper_flash_component_installer.cc File chrome/browser/component_updater/pepper_flash_component_installer.cc (right): http://codereview.chromium.org/11090018/diff/1/chrome/browser/component_updater/pepper_flash_component_installer.cc#newcode169 chrome/browser/component_updater/pepper_flash_component_installer.cc:169: (plugin.pepper_permissions & ppapi::PERMISSION_FLASH); On 2012/10/09 20:00:36, cpu wrote: > ...
8 years, 2 months ago (2012-10-09 20:52:39 UTC) #3
cpu_(ooo_6.6-7.5)
lgtm
8 years, 2 months ago (2012-10-09 22:32:40 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/bauerb@chromium.org/11090018/8001
8 years, 2 months ago (2012-10-10 07:54:40 UTC) #5
commit-bot: I haz the power
Presubmit check for 11090018-8001 failed and returned exit status 1. Running presubmit commit checks ...
8 years, 2 months ago (2012-10-10 07:54:49 UTC) #6
Bernhard Bauer
Hey John, can I get an OWNERS review for content/?
8 years, 2 months ago (2012-10-10 08:03:53 UTC) #7
jam
lgtm
8 years, 2 months ago (2012-10-10 19:23:48 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/bauerb@chromium.org/11090018/8001
8 years, 2 months ago (2012-10-10 20:03:27 UTC) #9
commit-bot: I haz the power
8 years, 2 months ago (2012-10-10 22:10:29 UTC) #10
Change committed as 161210

Powered by Google App Engine
This is Rietveld 408576698