Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(39)

Issue 11089002: Build content_main_runner.cc on iOS. (Closed)

Created:
8 years, 2 months ago by msarda
Modified:
8 years, 2 months ago
Reviewers:
stuartmorgan, jam
CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, jam
Base URL:
http://git.chromium.org/chromium/src.git@master
Visibility:
Public.

Description

Build content_main_runner.cc on iOS. This CL excludes the parts that are not supported on iOS like the creating a new process for content (Chrome on iOS runs in a single process). Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=161088

Patch Set 1 #

Patch Set 2 : Build content_main_runner.cc on iOS. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -8 lines) Patch
M content/app/content_main_runner.cc View 7 chunks +12 lines, -5 lines 0 comments Download
M content/content_app.gypi View 1 1 chunk +0 lines, -3 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
msarda
PTAL.
8 years, 2 months ago (2012-10-08 11:47:37 UTC) #1
msarda
CL description updated. PTAL.
8 years, 2 months ago (2012-10-08 11:59:56 UTC) #2
stuartmorgan
LGTM +jam for OWNERS
8 years, 2 months ago (2012-10-08 12:01:13 UTC) #3
jam
lgtm
8 years, 2 months ago (2012-10-10 04:09:17 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/msarda@chromium.org/11089002/5001
8 years, 2 months ago (2012-10-10 08:10:04 UTC) #5
commit-bot: I haz the power
8 years, 2 months ago (2012-10-10 12:24:29 UTC) #6
Change committed as 161088

Powered by Google App Engine
This is Rietveld 408576698