Issue 11088074: Files app: Update directory contents properly while Drive files are being fetched

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 11088074: Files app: Update directory contents properly while Drive files are being fetched (Closed)

Created:
8 years, 2 months ago by Vladislav Kaznacheev

Modified:
8 years, 2 months ago

Reviewers:
dgozman

CC:
chromium-reviews, rginda+watch_chromium.org, arv (Not doing code reviews), SeRya

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Files app: Update directory contents properly while Drive files are being fetched BUG=155253 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=162668

Patch Set 1 #

Total comments: 1

Created: 8 years, 2 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+6 lines, -3 lines)			Patch
	M	chrome/browser/resources/file_manager/js/directory_model.js	View		2 chunks	+6 lines, -3 lines	1 comment	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

dgozman

8 years, 2 months ago (2012-10-11 12:25:43 UTC) #2

LGTM

https://chromiumcodereview.appspot.com/11088074/diff/1/chrome/browser/resourc...
File chrome/browser/resources/file_manager/js/directory_model.js (right):

https://chromiumcodereview.appspot.com/11088074/diff/1/chrome/browser/resourc...
chrome/browser/resources/file_manager/js/directory_model.js:1086: * @return
{boolean} True if GDATA if fully mounted.
typo: if -> is

Expand Messages | Collapse Messages