Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(149)

Issue 11088074: Files app: Update directory contents properly while Drive files are being fetched (Closed)

Created:
8 years, 2 months ago by Vladislav Kaznacheev
Modified:
8 years, 2 months ago
Reviewers:
dgozman
CC:
chromium-reviews, rginda+watch_chromium.org, arv (Not doing code reviews), SeRya
Visibility:
Public.

Description

Files app: Update directory contents properly while Drive files are being fetched BUG=155253 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=162668

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -3 lines) Patch
M chrome/browser/resources/file_manager/js/directory_model.js View 2 chunks +6 lines, -3 lines 1 comment Download

Messages

Total messages: 2 (0 generated)
Vladislav Kaznacheev
8 years, 2 months ago (2012-10-11 12:17:13 UTC) #1
dgozman
8 years, 2 months ago (2012-10-11 12:25:43 UTC) #2
LGTM

https://chromiumcodereview.appspot.com/11088074/diff/1/chrome/browser/resourc...
File chrome/browser/resources/file_manager/js/directory_model.js (right):

https://chromiumcodereview.appspot.com/11088074/diff/1/chrome/browser/resourc...
chrome/browser/resources/file_manager/js/directory_model.js:1086: * @return
{boolean} True if GDATA if fully mounted.
typo: if -> is

Powered by Google App Engine
This is Rietveld 408576698