Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(294)

Issue 11088033: fix for compilation of gtest on VS2012 (Closed)

Created:
8 years, 2 months ago by scottmg
Modified:
8 years, 2 months ago
Reviewers:
cpu_(ooo_6.6-7.5)
CC:
chromium-reviews
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -1 line) Patch
M testing/gtest.gyp View 2 chunks +11 lines, -1 line 1 comment Download

Messages

Total messages: 6 (0 generated)
scottmg
https://codereview.chromium.org/11088033/diff/1/testing/gtest.gyp File testing/gtest.gyp (left): https://codereview.chromium.org/11088033/diff/1/testing/gtest.gyp#oldcode124 testing/gtest.gyp:124: ['OS=="android" or (OS=="win" and MSVS_VERSION=="2012")', { this was a ...
8 years, 2 months ago (2012-10-09 18:14:06 UTC) #1
cpu_(ooo_6.6-7.5)
lgtm
8 years, 2 months ago (2012-10-09 19:47:42 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/scottmg@chromium.org/11088033/1
8 years, 2 months ago (2012-10-09 19:48:13 UTC) #3
commit-bot: I haz the power
Retried try job too often for step(s) interactive_ui_tests
8 years, 2 months ago (2012-10-09 20:59:30 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/scottmg@chromium.org/11088033/1
8 years, 2 months ago (2012-10-09 21:03:03 UTC) #5
commit-bot: I haz the power
8 years, 2 months ago (2012-10-09 23:21:45 UTC) #6
Change committed as 160974

Powered by Google App Engine
This is Rietveld 408576698