Issue 11088006: Validator_ragel: disallow 16-bit form for SSE4 instructions (popcnt, lzcnt, tzcnt)

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 11088006: Validator_ragel: disallow 16-bit form for SSE4 instructions (popcnt, lzcnt, tzcnt) (Closed)

Created:
8 years, 2 months ago by Vlad Shcherbina

Modified:
8 years, 2 months ago

Reviewers:
khim

CC:
native-client-reviews_googlegroups.com

Base URL:
svn://svn.chromium.org/native_client/trunk/src/native_client

Visibility:
Public.

Validator_ragel: disallow 16-bit form for SSE4 instructions (popcnt, lzcnt, tzcnt) This is done to mimic prod. validator behavior. Prod. validator does not allow two non-rex prefixes, and these instructions use f3 (REP prefix) as opcode extension, so it can't be combined with data16 prefix. BUG= http://code.google.com/p/nativeclient/issues/detail?id=3076 TEST= validator_x86/testdata/sse4data16.test Committed: https://src.chromium.org/viewvc/native_client?view=rev&revision=9951

Created: 8 years, 2 months ago

(Patch set is too large to download)

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2935 lines, -2879 lines)			Patch
M	src/trusted/validator_ragel/gen/validator_x86_32.c	View	1	128 chunks	+2862 lines, -2875 lines	0 comments	Download
M	src/trusted/validator_ragel/unreviewed/general_purpose_instructions.def	View	1	3 chunks	+28 lines, -4 lines	0 comments	Download
A	src/trusted/validator_x86/testdata/64/sse4data16.test	View	1	1 chunk	+45 lines, -0 lines	0 comments	Download

Total messages: 2 (0 generated)

lgtm