Add KillAllBlocking() to android_commands.py.

Add KillAllBlocking() to android_commands.py.

This is needed by forwarder2 which needs to wait until the device_listener
tears down.


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=161092

[felipeg, 2012-10-08 13:38:20]

lgtm

[Philippe, 2012-10-08 13:41:14]

I'm adding Marcus, Isaac and John since he's also helping me today :)

This will hopefully help us fix some issues we have downstream on the
instrumentation bots.

I will cherry-pick that downstream once you approved it.

[John Knottenbelt, 2012-10-08 13:43:45]

https://chromiumcodereview.appspot.com/11088004/diff/1001/build/android/pylib...
File build/android/pylib/android_commands.py (right):

https://chromiumcodereview.appspot.com/11088004/diff/1001/build/android/pylib...
build/android/pylib/android_commands.py:499: sleep(wait_period)
Should this be time.sleep?

[Philippe, 2012-10-08 13:47:37]

https://chromiumcodereview.appspot.com/11088004/diff/1001/build/android/pylib...
File build/android/pylib/android_commands.py (right):

https://chromiumcodereview.appspot.com/11088004/diff/1001/build/android/pylib...
build/android/pylib/android_commands.py:499: sleep(wait_period)
On 2012/10/08 13:43:45, John Knottenbelt wrote:
> Should this be time.sleep?

Good catch!

[John Knottenbelt, 2012-10-08 13:51:50]

lgtm

[bulach, 2012-10-08 13:57:56]

lgtm, with nit:

https://chromiumcodereview.appspot.com/11088004/diff/6001/build/android/pylib...
File build/android/pylib/android_commands.py (right):

https://chromiumcodereview.appspot.com/11088004/diff/6001/build/android/pylib...
build/android/pylib/android_commands.py:494: self.RunShellCommand('kill ' + '
'.join(pids))
how about replacing 492-494 with:
if self.KillAll(process):

[Philippe, 2012-10-08 14:07:52]

https://chromiumcodereview.appspot.com/11088004/diff/6001/build/android/pylib...
File build/android/pylib/android_commands.py (right):

https://chromiumcodereview.appspot.com/11088004/diff/6001/build/android/pylib...
build/android/pylib/android_commands.py:494: self.RunShellCommand('kill ' + '
'.join(pids))
On 2012/10/08 13:57:56, bulach wrote:
> how about replacing 492-494 with:
> if self.KillAll(process):

Good point.

[commit-bot: I haz the power, 2012-10-08 14:12:33]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/pliard@chromium.org/11088004/10001

[commit-bot: I haz the power, 2012-10-08 14:53:48]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/pliard@chromium.org/11088004/4

[commit-bot: I haz the power, 2012-10-08 15:42:19]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/pliard@chromium.org/11088004/4005

[commit-bot: I haz the power, 2012-10-08 16:48:20]

Retried try job too often for step(s) interactive_ui_tests

[commit-bot: I haz the power, 2012-10-09 08:00:19]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/pliard@chromium.org/11088004/4005

[commit-bot: I haz the power, 2012-10-09 09:08:47]

Retried try job too often for step(s) interactive_ui_tests

[commit-bot: I haz the power, 2012-10-10 08:27:21]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/pliard@chromium.org/11088004/4005

[commit-bot: I haz the power, 2012-10-10 12:28:36]

Change committed as 161092