Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(142)

Unified Diff: vm/ast.cc

Issue 11087070: - Get rid of RawClosure class and use RawInstance for closures. (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/runtime/
Patch Set: Created 8 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « lib/isolate.cc ('k') | vm/code_generator.cc » ('j') | vm/code_generator.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: vm/ast.cc
===================================================================
--- vm/ast.cc (revision 13487)
+++ vm/ast.cc (working copy)
@@ -287,7 +287,7 @@
const Instance* ClosureNode::EvalConstExpr() const {
if (function().IsImplicitStaticClosureFunction()) {
// Return a value that represents a closure. Only the type is relevant.
- return &Closure::Handle();
+ return &Instance::Handle();
Ivan Posva 2012/10/11 04:04:22 This does not match with the comment. The type of
regis 2012/10/11 15:21:55 Shouldn't this be a ZoneHandle?
siva 2012/10/11 17:45:58 Changed comment to state that we return a dart ins
siva 2012/10/11 17:45:58 Checked with Mathias, he thinks it is ok to be a H
}
return NULL;
}
« no previous file with comments | « lib/isolate.cc ('k') | vm/code_generator.cc » ('j') | vm/code_generator.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698