Issue 11087067: Upstream deviceScaleFactor initialization in render_view_impl

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 11087067: Upstream deviceScaleFactor initialization in render_view_impl (Closed)

Created:
8 years, 2 months ago by Yusuf

Modified:
8 years, 2 months ago

Reviewers:
jamesr, aelias_OOO_until_Jul13

CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, jam

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Upstream deviceScaleFactor initialization in render_view_impl This change makes sure deviceScalefactor is initialized consistently with the deviceInfo value. BUG=136745 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=161365

Patch Set 1 #

Total comments: 1

Patch Set 2 : Got rid of the if check #

Created: 8 years, 2 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2 lines, -0 lines)			Patch
	M	content/renderer/render_view_impl.cc	View	1	1 chunk	+2 lines, -0 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

aelias_OOO_until_Jul13

http://codereview.chromium.org/11087067/diff/1/content/renderer/render_view_impl.cc File content/renderer/render_view_impl.cc (right): http://codereview.chromium.org/11087067/diff/1/content/renderer/render_view_impl.cc#newcode662 content/renderer/render_view_impl.cc:662: if (device_scale_factor != webview()->deviceScaleFactor()) { No need for this ...

8 years, 2 months ago (2012-10-10 22:14:12 UTC) #2

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/yusufo@chromium.org/11087067/4001

8 years, 2 months ago (2012-10-11 14:54:40 UTC) #4

Change committed as 161365

Expand Messages | Collapse Messages