Add common_resources.grd for non-localizeable chromoting resources.

Add common_resources.grd for non-localizeable chromoting resources.

The new common_resources.grd will be used for non-loalizeable resources, 
such as images.


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=162342

[Jamie, 2012-10-10 20:40:22]

lgtm, although I'm no expert on any of this stuff.

http://codereview.chromium.org/11087059/diff/1/remoting/remoting.gyp
File remoting/remoting.gyp (right):

http://codereview.chromium.org/11087059/diff/1/remoting/remoting.gyp#newcode1271
remoting/remoting.gyp:1271: 'action_name': 'string_resources',
Nit: Is there a convention that action names should be verbs? If so then maybe
generate_string_resources would be better.

http://codereview.chromium.org/11087059/diff/1/remoting/resources/resource_ids
File remoting/resources/resource_ids (right):

http://codereview.chromium.org/11087059/diff/1/remoting/resources/resource_id...
remoting/resources/resource_ids:23: "structures": [2000],
Any reason not to make this much larger? I doubt we'll ever hit 1000 strings,
but it's not completely impossible, and I guess we'll run into problems if these
ranges ever overlap. I'd suggest at least 10000.

[Sergey Ulanov, 2012-10-10 23:10:02]

Before landing this CL, I will need to land and roll grit change from
http://codereview.chromium.org/11085048/

http://codereview.chromium.org/11087059/diff/1/remoting/remoting.gyp
File remoting/remoting.gyp (right):

http://codereview.chromium.org/11087059/diff/1/remoting/remoting.gyp#newcode1271
remoting/remoting.gyp:1271: 'action_name': 'string_resources',
On 2012/10/10 20:40:22, Jamie wrote:
> Nit: Is there a convention that action names should be verbs? If so then maybe
> generate_string_resources would be better.

There is no such convention. In fact most action names are not verbs:
http://code.google.com/p/chromium/source/search?q=action_name+name+file%3Agyp...

http://codereview.chromium.org/11087059/diff/1/remoting/resources/resource_ids
File remoting/resources/resource_ids (right):

http://codereview.chromium.org/11087059/diff/1/remoting/resources/resource_id...
remoting/resources/resource_ids:23: "structures": [2000],
On 2012/10/10 20:40:22, Jamie wrote:
> Any reason not to make this much larger? I doubt we'll ever hit 1000 strings,
> but it's not completely impossible, and I guess we'll run into problems if
these
> ranges ever overlap. I'd suggest at least 10000.

Done, though I don't think it matters much - resource packs are shipped with the
binaries, so it will not be hard to change this value later.

[Jamie, 2012-10-10 23:40:41]

http://codereview.chromium.org/11087059/diff/1/remoting/resources/resource_ids
File remoting/resources/resource_ids (right):

http://codereview.chromium.org/11087059/diff/1/remoting/resources/resource_id...
remoting/resources/resource_ids:23: "structures": [2000],
On 2012/10/10 23:10:03, sergeyu wrote:
> On 2012/10/10 20:40:22, Jamie wrote:
> > Any reason not to make this much larger? I doubt we'll ever hit 1000
strings,
> > but it's not completely impossible, and I guess we'll run into problems if
> these
> > ranges ever overlap. I'd suggest at least 10000.
> 
> Done, though I don't think it matters much - resource packs are shipped with
the
> binaries, so it will not be hard to change this value later.

As long as there's an obvious error message if they overlap, you're right. I was
just concerned about hard-to-track-down bugs a year or more from now :)

[commit-bot: I haz the power, 2012-10-11 17:25:49]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/sergeyu@chromium.org/11087059/6001

[commit-bot: I haz the power, 2012-10-11 17:34:46]

Retried try job too often for step(s) compile

[commit-bot: I haz the power, 2012-10-11 18:00:46]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/sergeyu@chromium.org/11087059/5004

[commit-bot: I haz the power, 2012-10-11 18:00:50]

Can't process patch for file
remoting/resources/default_100_percent/chromoting16.png.
Binary file support is temporarilly disabled due to a bug. Please commit blindly
the binary files first then commit the source change as a separate CL. Sorry for
the annoyance.

[commit-bot: I haz the power, 2012-10-13 22:08:22]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/sergeyu@chromium.org/11087059/14001

[commit-bot: I haz the power, 2012-10-13 22:27:10]

Sorry for I got bad news for ya.
Compile failed with a clobber build.
Your code is likely broken or HEAD is junk. Please ensure your
code is not broken then alert the build sheriffs.
Look at the try server FAQ for more details.

[commit-bot: I haz the power, 2012-10-15 18:49:20]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/sergeyu@chromium.org/11087059/14001

[commit-bot: I haz the power, 2012-10-15 18:56:44]

Sorry for I got bad news for ya.
Compile failed with a clobber build.
Your code is likely broken or HEAD is junk. Please ensure your
code is not broken then alert the build sheriffs.
Look at the try server FAQ for more details.

[commit-bot: I haz the power, 2012-10-16 18:10:36]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/sergeyu@chromium.org/11087059/26001

[commit-bot: I haz the power, 2012-10-16 20:18:39]

Change committed as 162226

[commit-bot: I haz the power, 2012-10-16 23:40:53]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/sergeyu@chromium.org/11087059/29003

[commit-bot: I haz the power, 2012-10-17 08:14:20]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/sergeyu@chromium.org/11087059/29003

[commit-bot: I haz the power, 2012-10-17 10:13:28]

Change committed as 162342