Issue 11087047: Allow unaligned accesses for ARMv7.

Issue 11087047: Allow unaligned accesses for ARMv7. (Closed)

Created:
8 years, 2 months ago by ulan

Modified:
8 years, 2 months ago

Reviewers:
JF, Michael Starzinger

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

More Reviews

Description

Allow unaligned accesses for ARMv7. R=mstarzinger@chromium.org,jfb@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=12735

Patch Set 2 : Address comments #

Created: 8 years, 2 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+82 lines, -125 lines)			Patch
M	src/arm/assembler-arm.h	View		1 chunk	+3 lines, -0 lines	0 comments	Download
M	src/arm/assembler-arm.cc	View		2 chunks	+7 lines, -0 lines	0 comments	Download
M	src/arm/constants-arm.h	View		1 chunk	+0 lines, -4 lines	0 comments	Download
M	src/arm/macro-assembler-arm.cc	View		1 chunk	+11 lines, -11 lines	0 comments	Download
M	src/arm/regexp-macro-assembler-arm.h	View		1 chunk	+1 line, -0 lines	0 comments	Download
M	src/arm/regexp-macro-assembler-arm.cc	View		2 chunks	+8 lines, -3 lines	0 comments	Download
M	src/arm/simulator-arm.cc	View	1	2 chunks	+48 lines, -87 lines	0 comments	Download
M	src/flag-definitions.h	View		1 chunk	+2 lines, -0 lines	0 comments	Download
M	src/globals.h	View		1 chunk	+0 lines, -15 lines	0 comments	Download
M	src/regexp-macro-assembler.cc	View		1 chunk	+1 line, -5 lines	0 comments	Download
M	src/v8globals.h	View		1 chunk	+1 line, -0 lines	0 comments	Download

Messages

Total messages: 6 (0 generated)

Expand Messages | Collapse Messages

https://chromiumcodereview.appspot.com/11087047/diff/4001/src/arm/simulator-arm.cc File src/arm/simulator-arm.cc (right): https://chromiumcodereview.appspot.com/11087047/diff/4001/src/arm/simulator-arm.cc#newcode1072 src/arm/simulator-arm.cc:1072: } else if ((addr & 3) == 0) { ...

8 years, 2 months ago (2012-10-10 10:35:08 UTC) #2

Michael Starzinger

https://chromiumcodereview.appspot.com/11087047/diff/4001/src/arm/assembler-arm.cc File src/arm/assembler-arm.cc (right): https://chromiumcodereview.appspot.com/11087047/diff/4001/src/arm/assembler-arm.cc#newcode81 src/arm/assembler-arm.cc:81: answer |= 1u << UNALIGNED_ACCESSES; It seems the UNALIGNED_ACCESSES ...

8 years, 2 months ago (2012-10-10 11:11:19 UTC) #3

ulan

Uploaded new patch set. https://chromiumcodereview.appspot.com/11087047/diff/4001/src/arm/assembler-arm.cc File src/arm/assembler-arm.cc (right): https://chromiumcodereview.appspot.com/11087047/diff/4001/src/arm/assembler-arm.cc#newcode81 src/arm/assembler-arm.cc:81: answer |= 1u << UNALIGNED_ACCESSES; ...

8 years, 2 months ago (2012-10-10 12:13:28 UTC) #4

LGTM.

Expand Messages | Collapse Messages