Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(781)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 11087021: Cleanup: IWYU for base/time.h. (Closed)

Created:
8 years, 2 months ago by Lei Zhang
Modified:
8 years, 2 months ago
CC:
chromium-reviews, sadrul, nkostylev+watch_chromium.org, jam, amit, dcheng, markusheintz_, stevenjb+watch_chromium.org, sergeyu+watch_chromium.org, dcaiafa+watch_chromium.org, cbentzel+watch_chromium.org, kinuko+watch, ben+watch_chromium.org, kkania, joi+watch-content_chromium.org, lambroslambrou+watch_chromium.org, darin-cc_chromium.org, tzik+watch_chromium.org, erikwright+watch_chromium.org, tim (not reviewing), michaeln, jennb, wez+watch_chromium.org, Raghu Simha, sanjeevr, jianli, simonmorris+watch_chromium.org, feature-media-reviews_chromium.org, rmsousa+watch_chromium.org, oshima+watch_chromium.org, haitaol1, jamiewalch+watch_chromium.org, hclam+watch_chromium.org, mihaip-chromium-reviews_chromium.org, akalin, Dmitry Titov, garykac+watch_chromium.org, Aaron Boodman, eroman, robertshield, davemoore+watch_chromium.org, alexeypa+watch_chromium.org, mmenke
Visibility:
Public.

Description

Cleanup: IWYU for base/time.h. Also fix misc lint errors. TBR=ben,brettw,oshima,rdsmith Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=160999

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -52 lines) Patch
M ash/wm/session_state_animator.h View 2 chunks +1 line, -2 lines 0 comments Download
M base/message_pump_android.h View 1 chunk +2 lines, -1 line 0 comments Download
M base/message_pump_android.cc View 1 chunk +1 line, -0 lines 0 comments Download
M base/process_info.h View 1 chunk +2 lines, -1 line 0 comments Download
M base/sys_info.h View 1 chunk +0 lines, -1 line 0 comments Download
M base/threading/worker_pool_posix.h View 1 chunk +0 lines, -1 line 0 comments Download
M base/tracked_objects.h View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/automation/automation_tab_tracker.h View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/browsing_data/browsing_data_file_system_helper.h View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/browsing_data/browsing_data_quota_helper.h View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/browsing_data/browsing_data_quota_helper_impl.h View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/chromeos/login/user_manager.h View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/extensions/extension_pref_store.h View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/extensions/extension_service.h View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/net/chrome_net_log.h View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/net/crl_set_fetcher.h View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/password_manager/password_store_mac_internal.h View 2 chunks +1 line, -2 lines 0 comments Download
M chrome/browser/printing/cloud_print/cloud_print_setup_flow.h View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/sync/glue/typed_url_change_processor.h View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/sync/test/integration/passwords_helper.h View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/ui/cocoa/panels/panel_window_controller_cocoa.h View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/ui/webui/suggestions_internals/suggestions_internals_ui_handler.h View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/renderer/spellchecker/spellcheck.h View 1 chunk +0 lines, -1 line 0 comments Download
M chromeos/disks/mock_disk_mount_manager.h View 1 chunk +0 lines, -1 line 0 comments Download
M content/browser/device_orientation/provider_impl.h View 1 chunk +0 lines, -1 line 0 comments Download
M content/browser/geolocation/win7_location_api_win.h View 1 chunk +0 lines, -1 line 0 comments Download
M content/browser/renderer_host/gesture_event_filter.h View 2 chunks +2 lines, -3 lines 0 comments Download
M content/browser/renderer_host/resource_request_info_impl.h View 1 chunk +0 lines, -1 line 0 comments Download
M content/common/file_utilities_messages.h View 1 chunk +0 lines, -1 line 0 comments Download
M content/renderer/render_thread_impl.h View 1 chunk +0 lines, -1 line 0 comments Download
M media/audio/audio_output_controller.h View 1 chunk +0 lines, -1 line 0 comments Download
M media/audio/linux/cras_input.h View 1 chunk +0 lines, -1 line 0 comments Download
M media/audio/mac/audio_low_latency_input_mac.h View 1 chunk +0 lines, -1 line 0 comments Download
M media/webm/webm_tracks_parser.h View 1 chunk +0 lines, -1 line 0 comments Download
M net/base/crl_set.h View 1 chunk +0 lines, -1 line 0 comments Download
M net/base/crl_set.cc View 3 chunks +4 lines, -3 lines 0 comments Download
M remoting/base/running_average.h View 2 chunks +1 line, -2 lines 0 comments Download
M remoting/client/chromoting_client.h View 1 chunk +0 lines, -1 line 0 comments Download
M remoting/host/audio_scheduler.h View 1 chunk +0 lines, -1 line 0 comments Download
M ui/base/gestures/gesture_types.h View 1 chunk +0 lines, -1 line 0 comments Download
M webkit/appcache/appcache_service.h View 1 chunk +0 lines, -1 line 0 comments Download
M webkit/appcache/web_application_cache_host_impl.h View 2 chunks +1 line, -2 lines 0 comments Download
M webkit/fileapi/syncable/local_file_change_tracker.h View 1 chunk +0 lines, -1 line 0 comments Download
M webkit/plugins/npapi/webplugin_delegate_impl.h View 1 chunk +0 lines, -1 line 0 comments Download
M webkit/quota/quota_client.h View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 10 (0 generated)
Lei Zhang
8 years, 2 months ago (2012-10-09 07:09:22 UTC) #1
Wez
remoting/ LGTM
8 years, 2 months ago (2012-10-09 17:11:15 UTC) #2
jennb
panels LGTM
8 years, 2 months ago (2012-10-09 18:37:33 UTC) #3
akalin
sync lgtm
8 years, 2 months ago (2012-10-09 21:22:53 UTC) #4
akalin
lgtm mention that you do other misc. cleanup here and there (in the CL description)
8 years, 2 months ago (2012-10-09 21:40:26 UTC) #5
Lei Zhang
TBR the other owners for these trivial changes. ben: ash, ui brettw: base, content, webkit ...
8 years, 2 months ago (2012-10-09 22:22:45 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/thestig@chromium.org/11087021/1
8 years, 2 months ago (2012-10-09 22:23:00 UTC) #7
oshima
chromeos LGTM
8 years, 2 months ago (2012-10-09 23:42:27 UTC) #8
commit-bot: I haz the power
Change committed as 160999
8 years, 2 months ago (2012-10-10 01:25:16 UTC) #9
Randy Smith (Not in Mondays)
8 years, 2 months ago (2012-10-10 16:13:30 UTC) #10 
net LGTM.

Powered by Google App Engine
This is Rietveld 408576698